[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 1/4] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Mon, 20 May 2024 12:18:08 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUh//qIrrLC50lj3hr8be+GwwZhhSOoLCMvWd+b23UM=; b=Gr7aq9svVz5/W2iso9BBorj41tXPOE89xzp3SpS/Rc4Oh0nnoyn+mZD8q7++fwsTnzgg4UHN89s+RH8349USrRJ4YjcG5r9nDEwi8+NqJTOG0j8TUSXZZzgjlOpjvTyWUydYYuhCiYTweyuPpbYejXzSMMwmKYbj4NtXoOmtCsL77VEuqxDyTn/lqhVhzzyPfjyPkS51fIf+7DNi0eiEQZWGiTAQZwyBLj58AmyBRzy3ERnFWcbYQkHHpBAydAhqg4eU0ZZ/eoxfhBo8Z13AwzEhZl5OKZaYlR31l33h2dvTiZ7M59I1hwBPxzzMboLRKyWYY7DDt+H0R5+ste3KXg==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUh//qIrrLC50lj3hr8be+GwwZhhSOoLCMvWd+b23UM=; b=IV9PHOatfMUVM64zzSE1Fe7h2rRbxnuDvx1GChjBrEfGiXu7zOazV3M5kIf//zbYkeF4a1PcPUEF3cYZ3Zg2yi5BL7e/wfDh4MnUVM/K7scuBtw4W6zdwYryVD9oisRVVqYtEBIF4UemKYllN0HAO8ZAeq1LfQzRDWJNkE+0u9/mwM9TK6UdhhZ/N7plqVeLKF3QmLz2iZdreFreHjBiUKv3sdq37Lbz1LK5HGQ4hoNXswjfyhOszJ3c+A8J7Vzrm+YxRSelQtt5e2zsC2Gj8KewpcPiS+qWXlyIFcbJOHtAqoMzUl/D2AcSDc9ksImezNVw4WjjQoQ2Z8JzSSH3oQ==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eZJj6MsSFELARtQleGXiDxOa1EUEjN2ZC9grRkWN6CFeQAwI7ecWhhoycFb8va1uLeWV8BT5mfAyqChbNVDKYFtIQ3OUM4Ec/pYeGEhJJYbPGqO7aQOKlvCkRNKLLZ4bla8tla+MzsYaSIAsFjs1qPVIG4pI1eUNWQFS+qCvOl7dhXW5GViEktBSaifAoKJfygHusJWA0tXr6ilhbAxkzCwyPFSUEv2f2D5zCHoMsGzidzPCRu9ZNBv6hf6Qzhi7v6sA7ckfWhuEyRpdf7bHG8zZJ0htf6hEDnbypC5SNcrmBy1SJbORvyivMY0+gPr+Kq18MbZq/NZqiR4DsYD5Jg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cnr4he1qs8KlnENWz+pDG9L0+ymC+0yqYspNQeeB5PUef7h3RtpPG82J+CIwMoufaC36UJ5bjX3543yBzaDr3CKEGTHpW/v8bUBzp+TMk57TdIH/O+9MeiK5WKZvxV26NkYhKzlRPj+pmfDNRGgQdmfaZDx3QAMOufzA6UjHQLpnoOsni4FUezVi47ly+drZSlvQmytKiewBjV2HkHNfcAC9ulfd/n8VwjHHIppIsWhZZxw/0y1VJoY+K+dQC4CY/GphvmMfCsxMZFfKP2a7rmi7KlI3xQ9jXM7uVAVgl+F2P8CxEIFvLA6XFqwsgFs2fYEQuwNGgGWC7cjugccVZQ==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Henry Wang <xin.wang2@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Mon, 20 May 2024 12:18:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHaqqhXub4l7BSWRU+Wa81RtopbbLGgCi6A
  • Thread-topic: [PATCH v3 1/4] xen/arm/static-shmem: Static-shmem should be direct-mapped for direct-mapped domains


> On 20 May 2024, at 12:24, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> 
> Hi Henry,
> 
> +CC: Luca
> 
> On 17/05/2024 05:21, Henry Wang wrote:
>> 
>> 
>> Currently, users are allowed to map static shared memory in a
>> non-direct-mapped way for direct-mapped domains. This can lead to
>> clashing of guest memory spaces. Also, the current extended region
>> finding logic only removes the host physical addresses of the
>> static shared memory areas for direct-mapped domains, which may be
>> inconsistent with the guest memory map if users map the static
>> shared memory in a non-direct-mapped way. This will lead to incorrect
>> extended region calculation results.
>> 
>> To make things easier, add restriction that static shared memory
>> should also be direct-mapped for direct-mapped domains. Check the
>> host physical address to be matched with guest physical address when
>> parsing the device tree. Document this restriction in the doc.
> I'm ok with this restriction.
> 
> @Luca, do you have any use case preventing us from making this restriction?

Hi Michal, Henry,

I think it’s sensible, I don’t think we have any use case for direct-mapped 
domains using
non direct mapped static shared memory.

Cheers,
Luca


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.