[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-4.19? v4 1/6] x86/p2m: Add braces for better code clarity



On Sat, May 18, 2024 at 11:02:12AM +0000, Petr Beneš wrote:
> From: Petr Beneš <w1benny@xxxxxxxxx>
> 
> No functional change.
> 
> Signed-off-by: Petr Beneš <w1benny@xxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>

TBH I'm fine without the braces, but if lack of them can cause
confusion:

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

CODING_STYLE states that braces can be omitted for blocks with single
statements, I guess we should clarify whether multi-line statements
are accepted, as the example contains a single-line statement.

Thanks, Roger.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.