[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC XEN PATCH v8 5/5] domctl: Add XEN_DOMCTL_gsi_permission to grant gsi
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Fri, 17 May 2024 11:14:00 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VQs12np3lOboD0HaA3Llz13Ng4nYVMZwoFGR1yxNgWg=; b=ir8PBJo8ars1YdblgPf1N1NyZiU9lKbjDbbMkGBOKk0DAPkM3j5Op4oO9V0jfURH7GyWrkr6+2m862BQnuCdVed6DfRcG954QX2sPtQ1w9maBBOMlY1y4jPydRs/njNwbAkPBHbiyG9oCtiONBZHVNQzWkTUkp0sAIgACZoM19wnYYEmMk/AvNRdFwLpPY3Pmp2mQ+ljmdhbiodbn4J/Le3aaWUrFeJ/sJx9DXE3Rgyl5k+lm8CXy0EDnIpMsR0xq34fqNvE9YRCukz7LVSz2MBZf5z/8cOhn7am9IB5+KeQgeQLMrvXJcfoV7VfQ9giyytlF8Rm8DE/ZBCGO9IJFA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A0jzGPCcEh6xapv2SNOpkO3vzirhlYomzovMcsj/0OoTHGP9rU5hcF2vO8ApLxWTLJlaLsoj/9BGQue5x6IeR4O53zVdhhWjX7XOMG+KjmLID/JljgFSEvcn9p9NYkwFURXih6on9fLD6aZ5X8fm6Zw/9+BWWJqDm+/ckxKZGQ0fZjMT9JUO8a+Pu5+sp87s/wMZF0qrXf1dO5yF7kRQKlMit1XcUFFHPajdEoBkOgY2kvsbxTylRINitTQM7eU8AFFZl2gLIeGa7+rugl6zUu5DYIz/xRvyhuGs1uXrrjQKsmw1loZ6s3/TKwUVZp+de2jpPRnJmfmDXPvw15dCMw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Anthony PERARD <anthony@xxxxxxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, "Hildebrand, Stewart" <Stewart.Hildebrand@xxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Daniel P . Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Fri, 17 May 2024 11:14:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHap3bgiER4vYjwvk2+R5oTa8V63LGZ5EYAgAHVa4D//4e1AIAAis+A
- Thread-topic: [RFC XEN PATCH v8 5/5] domctl: Add XEN_DOMCTL_gsi_permission to grant gsi
On 2024/5/17 18:51, Jan Beulich wrote:
> On 17.05.2024 12:45, Chen, Jiqian wrote:
>> On 2024/5/16 22:01, Jan Beulich wrote:
>>> On 16.05.2024 11:52, Jiqian Chen wrote:
>>>> + if ( gsi >= nr_irqs_gsi )
>>>> + {
>>>> + ret = -EINVAL;
>>>> + break;
>>>> + }
>>>> +
>>>> + if ( !irq_access_permitted(current->domain, gsi) ||
>>>
>>> I.e. assuming IRQ == GSI? Is that a valid assumption when any number of
>>> source overrides may be surfaced by ACPI?
>> All irqs smaller than nr_irqs_gsi are gsi, aren't they?
>
> They are, but there's not necessarily a 1:1 mapping.
Oh, so do I need to add a new gsi_caps to store granted gsi?
And Dom0 defaults to own all gsis permission?
>
> Jan
--
Best regards,
Jiqian Chen.
|
