Re: [XEN PATCH 0/4] address violations of MISRA C Rule 20.7

["Oleksii K." <oleksii.kurochko@xxxxxxxxx>]

On Wed, 2024-05-15 at 09:48 +0200, Jan Beulich wrote:
> Oleksii,
> 
> On 15.05.2024 09:34, Nicola Vetrini wrote:
> > Hi all,
> > 
> > this series aims to refactor some macros that cause violations of
> > MISRA C Rule
> > 20.7 ("Expressions resulting from the expansion of macro parameters
> > shall be
> > enclosed in parentheses"). All the macros touched by these patches
> > are in some
> > way involved in violations, and the strategy adopted to bring them
> > into
> > compliance is to add parentheses around macro arguments where
> > needed.
> > 
> > Nicola Vetrini (4):
> >   x86/vpmu: address violations of MISRA C Rule 20.7
> >   x86/hvm: address violations of MISRA C Rule 20.7
> >   x86_64/uaccess: address violations of MISRA C Rule 20.7
> >   x86_64/cpu_idle: address violations of MISRA C Rule 20.7
> 
> for 4.18 we took a relaxed approach towards (simple) changes for
> Misra purposes.
> I wonder whether you mean to permit the same for 4.19, or whether
> series like
> this one rather want/need delaying until after branching.
Lets follow the same approach for 4.19.

Sorry for delayed answer.

~ Oleksii

> 
> Jan
> 
> >  xen/arch/x86/cpu/vpmu_amd.c               | 4 ++--
> >  xen/arch/x86/hvm/mtrr.c                   | 2 +-
> >  xen/arch/x86/hvm/rtc.c                    | 2 +-
> >  xen/arch/x86/include/asm/hvm/save.h       | 2 +-
> >  xen/arch/x86/include/asm/x86_64/uaccess.h | 7 ++++---
> >  xen/arch/x86/x86_64/cpu_idle.c            | 2 +-
> >  6 files changed, 10 insertions(+), 9 deletions(-)
> > 
>