[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC KERNEL PATCH v6 3/3] xen/privcmd: Add new syscall to get gsi from irq
- To: Jürgen Groß <jgross@xxxxxxxx>
- From: "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Date: Sat, 11 May 2024 02:16:07 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I0428Ijj/UEPn6TKWG5i49LAwCZg7A4VDslimAPxVGk=; b=LP5XWpBD4T0mCBG0xABBDSerDnCQx/3R+6c9T4bZr7dWoF4Htvq2MfmXI4yjXNwCCZKhp0WUTItMnVur5QfHO5fQB7fqS0TC3b7svQaOjOxZmRYqdfZuYKrRLRkY+wniLT3mr7CBlliJXSvtk43sEl2i7sUiCPlHI3bnGBzXGzYFJgIypE//2hx0ptlHxRO0rxzGqE1kmv1ffjGyR7Q/FUWqMcDVmNnViB/wXMRI7Pmqzpdg76mtjdynQbXyXSCK4U4y6iZojw8W0F2GOnKio6YsRIX9by1EtD8qTraP7a6xoqDy1osoXvkTz0tvjIigd0pLVh+EYULK3YS2hCAzzg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V6zng0vRYgHAQc4tkRtV9jCJ8FzCWb6t9J3ErKhz7yYiLfMHMVXFIk3aHvAamBAR6Ra+DaWXhTimhOUlUR5zyUEVSXLVMAjRCdgc1o/PIshQO+Z5hNkmOX8AOR+wEA9ox4BAajtm+ZQCtuBNiLIppWrDep1Rvb7bt/qQth9fJWoSxG4l2RHBEC0ow7FC5Faf7MheMJkYU29ygRTUtE18suoQRX6KpskSjmIRHaj5JSkl74vQb+lnh2tJky9UangCrHEjL87U/0GQcuy+nwNzuMP6eIyI6xAY6eoK3hTBb22O99dh+Jrjs4ccKb7w8hEA5V/hVSCcGlbbU1l4OhzePg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, "Rafael J . Wysocki" <rafael@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "linux-pci@xxxxxxxxxxxxxxx" <linux-pci@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-acpi@xxxxxxxxxxxxxxx" <linux-acpi@xxxxxxxxxxxxxxx>, "Huang, Ray" <Ray.Huang@xxxxxxx>, "Chen, Jiqian" <Jiqian.Chen@xxxxxxx>
- Delivery-date: Sat, 11 May 2024 02:16:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHakgrPZQMiHHEzE0Gs/TUOGsHh17GQJ2yAgACnAgD//41hgIAAiXAA//9+YoCAAIdwAP//iviAAC/BN4A=
- Thread-topic: [RFC KERNEL PATCH v6 3/3] xen/privcmd: Add new syscall to get gsi from irq
On 2024/5/10 19:27, Jürgen Groß wrote:
> On 10.05.24 12:32, Chen, Jiqian wrote:
>> On 2024/5/10 18:21, Jürgen Groß wrote:
>>> On 10.05.24 12:13, Chen, Jiqian wrote:
>>>> On 2024/5/10 17:53, Jürgen Groß wrote:
>>>>> On 10.05.24 11:06, Chen, Jiqian wrote:
>>>>>> Hi,
>>>>>>
>>>>>> On 2024/5/10 14:46, Jürgen Groß wrote:
>>>>>>> On 19.04.24 05:36, Jiqian Chen wrote:
>>>>>>>> +
>>>>>>>> + info->type = IRQT_PIRQ;
>>>>>> I am considering whether I need to use a new type(like IRQT_GSI) here to
>>>>>> distinguish with IRQT_PIRQ, because function restore_pirqs will process
>>>>>> all IRQT_PIRQ.
>>>>>
>>>>> restore_pirqs() already considers gsi == 0 to be not GSI related. Isn't
>>>>> this
>>>>> enough?
>>>> No, it is not enough.
>>>> xen_pvh_add_gsi_irq_map adds the mapping of gsi and irq, but the value of
>>>> gsi is not 0,
>>>> once restore_pirqs is called, it will do PHYSDEVOP_map_pirq for that gsi,
>>>> but in pvh dom0, we shouldn't do PHYSDEVOP_map_pirq.
>>>
>>> Okay, then add a new flag to info->u.pirq.flags for that purpose?
>> I feel like adding "new flag to info->u.pirq.flags" is not as good as adding
>> " new type to info->type".
>> Because in restore_pirqs, it considers " info->type != IRQT_PIRQ", if adding
>> " new flag to info->u.pirq.flags", we need to add a new condition in
>> restore_pirqs.
>> And actually this mapping(gsi and irq of pvh) doesn't have pirq, so it is
>> not suitable to add to u.pirq.flags.
>
> Does this mean there is no other IRQT_PIRQ related activity relevant for
> those GSIs/IRQs?
Yes, I think so.
> In that case I agree to add IRQT_GSI.
Thank you!
>
>
> Juergen
--
Best regards,
Jiqian Chen.
|
