Re: [PATCH] xen/build: Use -Wflex-array-member-not-at-end when available

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Fri, 10 May 2024, Andrew Cooper wrote:
> This option is new in GCC-14, and maps to MISRA Rule 1.1.  The codebase is
> clean to it, and Eclair is blocking.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> CC: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
> 
> I really ought to have posted this before we regressed the tree, but oh well.
> Better late than never.
> ---
>  xen/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/Makefile b/xen/Makefile
> index b6c39fc6aefb..71f0cb5071b3 100644
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -396,6 +396,7 @@ CFLAGS += -nostdinc -fno-builtin -fno-common
>  CFLAGS += -Werror -Wredundant-decls -Wwrite-strings -Wno-pointer-arith
>  CFLAGS += -Wdeclaration-after-statement
>  $(call cc-option-add,CFLAGS,CC,-Wvla)
> +$(call cc-option-add,CFLAGS,CC,-Wflex-array-member-not-at-end)
>  CFLAGS += -pipe -D__XEN__ -include $(srctree)/include/xen/config.h
>  CFLAGS-$(CONFIG_DEBUG_INFO) += -g
>  
> -- 
> 2.30.2
>