Re: [PATCH v3 5/5] Add --force option to xen-ucode to override microcode version check

[Fouad Hilly <fouad.hilly@xxxxxxxxx>]

On Mon, May 6, 2024 at 10:39 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 30.04.2024 14:47, Fouad Hilly wrote:
> > @@ -21,10 +23,11 @@ static const char   amd_id[] = "AuthenticAMD";
> >  static void usage(const char *name)
> >  {
> >      printf("%s: Xen microcode updating tool\n"
> > -           "Usage: %s [<microcode file> | Options]\n"
> > +           "Usage: %s [microcode file] [options]\n"
> >             "options:\n"
> >             "  -h, --help            display this help and exit\n"
> > -           "  -s, --show-cpu-info   show CPU information and exit\n",
> > +           "  -s, --show-cpu-info   show CPU information and exit\n"
> > +           "  -f, --force           force to skip micorocde version 
> > check\n",
>
> Besides (nit) the typo, isn't "version check" too broad here? Elsewhere in the
> series you mention Intel's "min_rev" addition. _That_ kind of version check
> probably shouldn't be permitted to skip? In which case maybe better "certain
> version checking" or some such?
I will remove "min_rev" mention from this patch series. The main
reason for this change is to allow developers to downgrade microcode.
>
> Jan