[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v1 1/7] x86/vpmu: separate amd/intel vPMU code
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
- Date: Tue, 30 Apr 2024 12:07:00 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=40zcA97ST9wQF7hGAJgPg3VXMck8koPpSmG8zTQcNMk=; b=J+wNU/9Y5cvW53d23ZXwIyi2anR/Kgj2K7RsgicjGxoHA7CE+Uli+Ymyap6wHZorfe59JnAag/PYH0PrsWxybRkXpLwu1NchKWQmTWH9Y5Y1cEhA4aubddB4y6FA/76NOKfg+/X4PKy4impMat7Qtj26thetHMbqUBxwyPlgzSeE8soxbV38a9yWh66QbeGNyaF4+XezDvUafR2/NJvclrIhWEbxRnsduhpJVVc2k1Xsz8BlZFfAtaYfamPRB9oK+uC8gYjRKzzwbEDwTD0kX50bhlh8TfHlGuNNF2fxxsDDKEdLoiE84O8aPrtJ0yHJS4UGVt3WpXTIjH0u990Zjw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HPBKQXiQHI5K3D3E0+KQqj82OzGwxZcIsVk4FlnLmFdkLySuyz2m2O8aqjwWMcamxLyb2mr7Hgrn3PVL4II8QjDYncxSLDt20BQh45p1lEedelCVobwGH6LcbPo3G+cHr6Hn0c+toQPi5rfV137TxkzaMi0auEjRqytfeNmzj0mQiM0UD089uOwTv3pgGgAW7yBR7emJPEbqPaQ/fiWVJM5Bt9AbKXi+wnUlmIt1UpDmQESBE20ZCAavXHxX32PMXuZOyg4+D+Exe8hxGUS5h/zkt8ShZbDLZ6pJp3O4ayOE0FhE50QKfknawSw0V/ymvHr4RzxgznAIzUUCQAOuPg==
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 30 Apr 2024 09:07:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
29.04.24 18:28, Jan Beulich:
Any reason you don't follow the approach used in patch 7, putting simple
#ifdef in the switch() in vpmu_init()? That would avoid the need for the
three almost identical stubs.
I didn't want to put that many preprocessor statements into this small
switch() block (4 #ifdef/#endif-s per 15 LOC) but if it's ok I'll do it.
-Sergiy
|