[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH 1/2] tools/{c,o}xenstored: Don't link against libsystemd
On Thu, Apr 25, 2024 at 06:32:15PM +0100, Andrew Cooper wrote: > libsystemd is a giant dependency for one single function, but in the wake of > the xz backdoor, it turns out that even systemd leadership recommend against > linking against libsystemd for sd_notify(). > > Since commit 7b61011e1450 ("tools: make xenstore domain easy configurable") in > Xen 4.8, the launch-xenstore script invokes systemd-notify directly, so its That's not enough, it's needs to be `systemd-notify --ready` to be a replacement for sd_notify(READY=1). > not even necessary for the xenstored's to call sd_notify() themselves. So, sd_notify() or equivalent is still necessary. > Therefore, just drop the calls to sd_notify() and stop linking against > libsystemd. Sounds good, be we need to replace the call by something like: echo READY=1 > $NOTIFY_SOCKET implemented in C and ocaml. Detail to be checked. Otherwise, things won't work. Thanks, -- Anthony PERARD
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |