[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm/vpci: make prefetchable mem 64 bit
- To: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 25 Apr 2024 08:15:35 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lMxc1pNjk5ztSLrJ8+E10iK89P5wq6JGiR//k0syEOg=; b=EIXDY1CmiV85FmXrLKShVZyOk4L84WcWZhBgPPf/32TmdWTrldNi5baBDQ1vijv4cTE2e1OJnVMKw28hAoSLUHtYTb+2y4D7j4/NeqiEfUj8PBulgPi+irdhRastk1dz/DC/wksBpkfVnzZP0vKh7J5u8xZP05cgN6GAE13S9Sy7kBhanjdLRL1pNuUcWWPzeLfsrZb90Ejn9PrhUBcZohWhntVjkC7TXQDXs9bg5a2Cixm2Q9rOlKel17gjyZYQkRiTFb+bWdy6IRAjMHYAkYXHh1FwIekqJD2iYd/rL1AG2wH5QhLRkH5BwD8ZJb/iTVEHeXpfHUObVbTyA9VD4A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j0KgmFL8Lr4kQ/g1XZO4a4IkXShPZsldLVX9wlCYr1ItjeOOUmZFvDqmjowEyJdXTJORLyxT3hvvfmTuTbJ0FvY3FbEK9AVwT48KBD4WEMRHqP76CwEKFIQi66grFOUocfKxYuPOBpy0xZAg6wAxfDcTPMbhc0KU/ZvtfsA41g8m7fbp9NTLc5qehBmZrNoj8SjX2qdBXf/Jn67A4+4lf50ycbtuWHkSvYYQk/buHESzsFenYX+h64Pygocsv6B13lx3LFi3gxZlS2e6B6jtbMor8zDiKdxQObUoGN7tdpj+vaazQ7n5x5cUdngtMNuTi8DW0KAty8HqQCNUEMQ/rQ==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 25 Apr 2024 06:15:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Stewart,
On 24/04/2024 18:27, Stewart Hildebrand wrote:
> The vPCI prefetchable memory range is >= 4GB, so the memory space flags
> should be set to 64-bit. See IEEE Std 1275-1994 [1] for a definition of
NIT: would be beneficial to provide chapter (in this case 2.2.1.1)
> the field.
>
> [1] https://www.devicetree.org/open-firmware/bindings/pci/pci2_1.pdf
>
> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
Acked-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
> ---
> xen/include/public/arch-arm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> index e167e14f8df9..289af81bd69d 100644
> --- a/xen/include/public/arch-arm.h
> +++ b/xen/include/public/arch-arm.h
> @@ -487,7 +487,7 @@ typedef uint64_t xen_callback_t;
> #define GUEST_RAM0_SIZE xen_mk_ullong(0xc0000000)
>
> /* 4GB @ 4GB Prefetch Memory for VPCI */
> -#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x42000000)
> +#define GUEST_VPCI_ADDR_TYPE_PREFETCH_MEM xen_mk_ullong(0x43000000)
> #define GUEST_VPCI_PREFETCH_MEM_ADDR xen_mk_ullong(0x100000000)
> #define GUEST_VPCI_PREFETCH_MEM_SIZE xen_mk_ullong(0x100000000)
>
>
> base-commit: 410ef3343924b5a3928bbe8e392491992b322cf0
|
