Re: [XEN PATCH 1/2] pci: add suffix 'U' to PCI_CONF_ADDRESS macro.

[Alessandro Zucchelli <alessandro.zucchelli@xxxxxxxxxxx>]

On 2024-04-24 14:47, Jan Beulich wrote:
> On 24.04.2024 14:11, Alessandro Zucchelli wrote:
> > This addresses violations of MISRA C:2012 Rule 7.2 which states as
> > following: A “u” or “U” suffix shall be applied to all integer 
> > constants
> > that are represented in an unsigned type.
> >
> > No functional change.
> >
> > Signed-off-by: Alessandro Zucchelli <alessandro.zucchelli@xxxxxxxxxxx>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> > --- a/xen/arch/x86/x86_64/pci.c
> > +++ b/xen/arch/x86/x86_64/pci.c
> > @@ -9,7 +9,7 @@
> >  #include <asm/io.h>
> >
> >  #define PCI_CONF_ADDRESS(sbdf, reg) \
> > -    (0x80000000 | ((sbdf).bdf << 8) | ((reg) & ~3))
> > +    (0x80000000U | ((sbdf).bdf << 8) | ((reg) & ~3))
> >
> >  uint8_t pci_conf_read8(pci_sbdf_t sbdf, unsigned int reg)
> >  {
> This is x86'es PCI, so the subject prefix may ant to be "x86/pci:".
Noted, thanks.

--
Alessandro Zucchelli, B.Sc.

Software Engineer, BUGSENG (https://bugseng.com)