Re: [PATCH] x86/MTRR: avoid several indirect calls

[Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Jan 17, 2024 at 10:32:53AM +0100, Jan Beulich wrote:
> --- a/xen/arch/x86/cpu/mtrr/main.c
> +++ b/xen/arch/x86/cpu/mtrr/main.c
> @@ -328,7 +316,7 @@ int mtrr_add_page(unsigned long base, un
>       }
>  
>       /*  If the type is WC, check that this processor supports it  */
> -     if ((type == X86_MT_WC) && !have_wrcomb()) {
> +     if ((type == X86_MT_WC) && mtrr_have_wrcomb()) {

Is reversing the condition intentional here? 

>               printk(KERN_WARNING
>                      "mtrr: your processor doesn't support 
> write-combining\n");
>               return -EOPNOTSUPP;

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

Attachment: signature.asc
Description: PGP signature