[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v1 05/15] x86/p2m: move altp2m-related code to separate file
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
- Date: Fri, 19 Apr 2024 09:41:26 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GulJ1d412oYXl06ZPsjwTwmXkwtWKEQhJlb0LYN14VM=; b=PZLw7slpVk5Tyc5UxyzIv3um2+dFzz99enLhR+vvodgRWYuZxTlx6blrHgCBXcmi+HJ/oZszeLOcSYqDTmTWrvbik09JFh4+KOe71VmfRlukaVuE/Gwg5l1+Su27dORAJF/QUCJPvsRn9PJnJHhR0UUqnAingwjlFhdrawLCY/nNUIfSOnUshYWA5E6emyX4jQTrgZOwe9ypGNL3QOSMGPSpbZdjLBLZhv7e4CHkucWgeGBFXWsWhxNUybgVHD2gHpJQV4ZyO1vcs9BXbn0C9Zp9BkaFmg023X6G1QnbxxbwiQdjwroN53O6Gd7pDhQ6NUInVmQaAjfMCusLdToUjQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jRzKHbW9kbIXCq7luBYXxy+i9+9HYBf+50J5ahWgUl3gL7nzZisr6317u43PPvwjdScMkpPp/9jRc17ix+wOz0TOxXuG7aMMnOO61gkFV+CjJx99cf9m8fjVF9Nxc5Pf5zvh1zd2GK4BFJXud/0iMUffTmLMbtQOnQdCg3cbOMX4tdljbpbsv+uwu3WOzvqSSzU1CD71QeRbpzjOb411XUz59rTdZFh+9TE0/H+WJ6lIJIwHNyGClWvx8Sqnt1Qsl6Q+412v2RicI8PBeCB920GGvJZZChR9C1Xy708UmwZW1MppXyqkxnowPPouaosYvIrFWXXlrC1Q1GbYgpt0OA==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 19 Apr 2024 06:41:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
18.04.24 14:36, Jan Beulich:
On 16.04.2024 08:29, Sergiy Kibrik wrote:
Move altp2m code from generic p2m.c file to altp2m.c, so that VMX-specific
code is kept separately and can possibly be disabled in the build.
The code movement is desirable, but the reasoning isn't quite right (see
replies on other sub-threads).
understood
--- a/xen/arch/x86/mm/altp2m.c
+++ b/xen/arch/x86/mm/altp2m.c
@@ -9,6 +9,8 @@
#include <asm/altp2m.h>
#include "mm-locks.h"
#include "p2m.h"
+#include <public/hvm/hvm_op.h>
+#include <xen/event.h>
Please add above the private header #include-s.
ok
[...]
+ return rc;
+}
+
+
No double blank lines please, anywhere.
yes, go it
--- a/xen/arch/x86/mm/p2m.c
+++ b/xen/arch/x86/mm/p2m.c
@@ -500,9 +500,8 @@ int p2m_alloc_table(struct p2m_domain *p2m)
return 0;
}
-static int __must_check
-p2m_remove_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
- unsigned int page_order)
+int __must_check p2m_remove_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn,
+ unsigned int page_order)
{
And no unrelated re-formatting please (i.e. you really only need to
touch a single line here).
will fix that
-Sergiy
|
