[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v1 08/15] x86/vpmu: separate amd/intel vPMU code
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Sergiy Kibrik <sergiy_kibrik@xxxxxxxx>
- Date: Thu, 18 Apr 2024 16:25:53 +0300
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Rhm86dB95fQfrtJ5c1vl6iHequ7334ASotL5EtvKf7Y=; b=nkWsU8LrNXvyyXyTP5lz6xflh2KxSNH6vxap8tDoVfN2cSA3D7wAMRx7oNaHBdh2LNfRl1WzPvN7Tle8JvuNFOSLycI2/7gJhfM7kKW3wCEf78D45dkSNAfsyF2YsVFbah9DJ2EmiRvA5Zyo8mPjIPY63/m95KURJQ6kRme0mI1dvQv4r5xmQISkmAudqmRV2Spks/NOsViHTyrQuQECz8iUZ7FBN4LglA8UDCkHNaEeiEuqgf9yDATsGVseavZf6FnbV0+RfAzLCyff6YXwHGryUfIGvSoccU/8p4mnQF9NN3eAMuAdJPEm2GD9ijA1NI59vb4JgrEm1MBXRrZODg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SRmSVeNod0dUUqAD4UgFcAhNq+faT0Uu17JRY0Iax72nCgrl/XVgUij5pQ7JkmmpUQfTx5tt5TTGbulKrtdg99FASughaYn/NPUVcnMFFm2uzE6O+kwe5hlpZL9J6GOCAddkzGBuz9inej4E31f1Bi+zjkdqNB6Zd10NbdbLgMfcpewHeCYvdV1n6r3Pp8G1AFo5MUBuhvYZK5e3JsxT6hvcjsTCiNNsn8mHOLpsXXjMmvPHedCPCxEesd0QX5JFZDzUvUxCtB1xCN+PbCQtsJu+GNH/3MDBq/dP/NIAVvriEV6JGt3f1+cO4ldU8WB+SRT9CcgCgWsLX8N4GwumGA==
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- Delivery-date: Thu, 18 Apr 2024 13:26:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
16.04.24 14:05, Andrew Cooper:
On 16/04/2024 7:35 am, Sergiy Kibrik wrote:
diff --git a/xen/arch/x86/cpu/Makefile b/xen/arch/x86/cpu/Makefile
index 35561fe51d..d3d7b8fb2e 100644
--- a/xen/arch/x86/cpu/Makefile
+++ b/xen/arch/x86/cpu/Makefile
@@ -10,4 +10,6 @@ obj-y += intel.o
obj-y += intel_cacheinfo.o
obj-y += mwait-idle.o
obj-y += shanghai.o
-obj-y += vpmu.o vpmu_amd.o vpmu_intel.o
+obj-y += vpmu.o
+obj-$(CONFIG_SVM) += vpmu_amd.o
+obj-$(CONFIG_VMX) += vpmu_intel.o
I'm afraid this breaks perf counters on PV guests. These files are
joint guest-type implementations.
Seeing as you leave vpmu.o alone, I guess that all you're actually
wanting to do is compile out vpmu_intel.o? In which case, use
CONFIG_{AMD,INTEL} rather than CONFIG_{SVM,VMX} please.
Thanks for pointing that out.
I think I'll just exclude this patch from the series, and make a
separate series with CONFIG_{AMD,INTEL} option and code separation that
unrelated to VMX/SVM & HVM/PV, only to CPUs themselves.
BTW, how would you suggest CONFIG_{AMD,INTEL} shall relate to
CONFIG_{SVM,VMX}? Should CONFIG_VMX just plainly depend on CONFIG_AMD,
or more complex relations needed?
-Sergiy
|
