[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] public: xen: Define missing guest handle for int32_t


  • To: Michal Orzel <michal.orzel@xxxxxxx>
  • From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
  • Date: Wed, 17 Apr 2024 12:52:01 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
  • Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PqqnQW2idipp9wdIcg2k1TrPdfHpgJNzO2tWzS4qzFU=; b=JAiQfX7t04bFlyBKFGJst9GTU/5a7rz4vcFfcKm+N3FUY3ZAcgNsQ9j6gOQkHRJdRXhiw3YZvhG1VOTucycKbZ+/+iBuO3/+bgS7ZYOK7KrFjTOxo+H00y2RA3gY6MMNCa3cVS6LMVsN6tsq80JthZhK0JoCN8u7PqSRVCUPGaGBOnsTQAkAVsC3thfjuyWJXAIj5IxnET84oqvtlePKPUDfsTfw36IGOiRUzRIWhaVVLOXPKrYSeJKioM13W2opRjx8gjaD5qiJCw+BYNxi12EAi8hP7ymME8Wd/uTO139DxBuYCwZo6DlHJsbp2H2U05+r8dt128c5Ug7Yglu/zA==
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PqqnQW2idipp9wdIcg2k1TrPdfHpgJNzO2tWzS4qzFU=; b=NcQS4Jng08zNFblhEgbl7sQUFXkIseOMCXhksioa1fHVnb+hpQBKJNqCarwB0moqINMdfrOtHHoMIGh9mE11LEj7v5PmmuiAbV45HDySi+QhUV+4vZ9QURZ6apyeAQlEpCTXCvkZNJTp0cCoe69AcgO26FQvIJE9YFJEaQRChyAZqc4pKnynHcAmJxA40YTArb3dwtcGU4XFQMreBznlu+UZ0z1YxEtPKwj9QwypqtlKs58Z22UP4rK7mdbsKR9PjAISdlcdC/Yv7uOj1pS+PX4/9/iLpUPkZBBo40x3H99PlJumidMQotOsagU3zO/VEZZj3EQrFxCWv04rvIXOCw==
  • Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lzsUoYtZu3QkQ8qCQRnfGEZ6+1ZKYdyrzZxg2KTSMsn92fpUZjO7BasbfsJCWhnCk3Fv+qQj+QN+gbgLgvSEv5VhIq7h3ljilevbBY8J6lH9VTUygmxVnDdjf17Go7YIRCjxBku4Cq9NcIuWKuoJQdLnlxxIPrDwAxByDYp6nTnbqpzgP6IS4/wfTxtRhwzqSQUu396wb7Kr8PJpvjdyjDtWYldUMRrnpx7Y10CIXfD1XkZ9Rqk0NnhSDLhJ49z6VTzqe+CCX+Z169p2BbDvQQH5mUHA67AIuRGxfnVzcTax2oGWNd3RUhKQbM2wEJTE7X2sdcPWjvs/jll2KS9iSw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EqdtE46clF6UaY76Uv7e2s7viC5NJQIlWE+OI3OrEltNsLI4Bq4U/MPgqfRfzsiQiqBN7M+qGt+1dHKPIdNeQxXa+vL4k3siYSLtZjCt6hA7uTWlDN94Pk9v2tDGB49ZvOL+gP3g615FuyKOygEMJAKXK3qbSzPJEqO2kx5VYj9aa9wa4+ejSdxVDLEXUBm8JWZLv/Wuufq2LH7gczlUC29HIhaPMcjVahOlRs7kj+WnhEruvXh3lDlk3iJ4QUH1iNJsUbbSrU/nB2+a0C1Su2h5WcnNjBP6Bi3CghA0pR1jnT3wcNOLZhNhU9DBDnEpDMYZargQAD4m5mwIGmQP3w==
  • Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Wed, 17 Apr 2024 12:52:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Nodisclaimer: true
  • Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
  • Thread-index: AQHakMDnwJgPHKtLG0OvN5jC+71RJbFsaoaA
  • Thread-topic: [PATCH] public: xen: Define missing guest handle for int32_t

Hi Michal,

> On 17 Apr 2024, at 13:14, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> 
> Commit afab29d0882f ("public: s/int/int32_t") replaced int with int32_t
> in XEN_GUEST_HANDLE() in memory.h but there is no guest handle defined
> for it. This results in a build failure. Example on Arm:
> 
> ./include/public/arch-arm.h:205:41: error: unknown type name 
> ‘__guest_handle_64_int32_t’
>  205 | #define __XEN_GUEST_HANDLE(name)        __guest_handle_64_ ## name
>      |                                         ^~~~~~~~~~~~~~~~~~
> ./include/public/arch-arm.h:206:41: note: in expansion of macro 
> ‘__XEN_GUEST_HANDLE’
>  206 | #define XEN_GUEST_HANDLE(name)          __XEN_GUEST_HANDLE(name)
>      |                                         ^~~~~~~~~~~~~~~~~~
> ./include/public/memory.h:277:5: note: in expansion of macro 
> ‘XEN_GUEST_HANDLE’
>  277 |     XEN_GUEST_HANDLE(int32_t) errs;
> 
> Fix it. Also, drop guest handle definition for int given no further use.
> 
> Fixes: afab29d0882f ("public: s/int/int32_t")
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---

I’ve build it for arm64, arm32 and x86

Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.