[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: docs/misra: add R21.6 R21.14 R21.15 R21.16
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 17 Apr 2024 07:58:19 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LM47rY0ny9PItD6LeIXl3dYrjz9odm4K3JitDuEleLw=; b=d1q86OLHde1ysaT4PfPQ7P9FiiFU+fXHge2gChctlp+VvCA0VywyHA4iGjFssNo226nkomsghu8UhYWV7tA+xZgzFoya4T/w936fUGA53WqxgNC7FW2mBh2JPU51vkELMLPPvCUVo2qKxjBRBIigxX3VBnGxw4es8UYIaipvQsTKBxE893NgCuBai7DzBYYWs9drIJhDPk7T+p1aICOStFdM3FZ3MtIYuQddUmiNfv482V4t7gr8Hz0aVsTNDbvz8cxmHddQry5s+FyQd6f0PPqavLqUeHt4GJBonTop2hGKWkGVaf/kSbRHczeeHzF2+0PaZPqMLc4tFCFSOY9CiQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LM47rY0ny9PItD6LeIXl3dYrjz9odm4K3JitDuEleLw=; b=BVylkRvJtfKrsgZhpzbA++iMcUjxHr4Q57xsIpfTg/Ya53JHWL9LjElRs7lfh9zcMmiE0hdB2OJKt+dY1kx/6cs6SpxuaZPS81bdYRKBRtmUKEm+rUsFqmbYodCJQFvezsT55eLdqJT/qR+qftTyu5pIJUSyzN6k25nqdbegV6PogILfUzo6YjXX7tTAIUfLe4b4cBqmA/p6xikD5G/lRCSSRX9k7MxGXtI35bPYKNrfOih6LpyekDttcPZFS3BJl7nfTbQTkQT0rQ0aMx0byJXqtQKSDShKmTIqT545PIJsgTna6j3BShX1KqRGbSWd1Ga922tQb7xNpUg4sHKq6g==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aZwX/UG5WZeWr2wna3fRkHBxQQdF3C1AIAYryYR/AFd0LWnnpwGXEKFhVI1i1P5066vWq758jOyHPvuL4vEkEfo+ijgP6Lf7Ll3iiAPbrQRJCtQ2hp6MXltwQZc2MYYy7j/uxeMG0Dq7w9zAdJ3KDEFXR8TJP9J+vMdkDk+vYxIZKGbVlqZv7q4/KbgqMtX/H2F2kG7VWhGENe29o7PJm9j/3OUBdfQ7gi2PfWzseXWZm3lVnI1oE/YZGPbAr26tKgENBPaMjkZpC9r1TNjYP5WE/zsYmnCOPA/KSTKqnGvk95QxKSWgjh5w7gLnw+liAvmaFQ0dC1TsGjJwVY8XMA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nw7YixRiCiHW5PPWj2CHWjPBGz6xDtr8Z9e8SOqY0uNl7iRUbdbkS6xjgb4kp4Eu/1XT5Pyao4YDNzOnjZfOz47T+obff1gyB4TP+bw1nGjOo4KHbIaD5TKyGH59/pCohmnJe0YmSB7LtwBa4MNP03OfRjxA5/GglimeeC7/dLRigktN7CdhnqrR6Squ22HWo/+4tU6sAH7RzhKeEmwAb4d9zvgGi91Vbt+AlwcGSZKN/jhGrSfg7tD36W8KTJ/k2V2kRtJs4ZyjLGnL2kTY724DzTihARmdwdYSpdc/1nNtond5gcOEIDbbewiBRVBSooRQzu9YTy3jgpHTsLOmTA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>
- Delivery-date: Wed, 17 Apr 2024 07:59:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHakDQ428r7u0beA0yxVf0iyBBMbbFsGZCA
- Thread-topic: docs/misra: add R21.6 R21.14 R21.15 R21.16
Hi Stefano,
> Other deviations:
> -----------------
>
> diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst
> index b7b447e152..00db02ad34 100644
> --- a/docs/misra/rules.rst
> +++ b/docs/misra/rules.rst
> @@ -652,12 +652,38 @@ maintainers if you want to suggest a change.
> declared
> - See comment for Rule 21.1
>
> + * - `Rule 21.6
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_21_06.c>`_
> + - Required
> + - The Standard Library input/output routines shall not be used
> + - See the snprintf() and vsnprintf() deviation in deviations.rst
> +
> * - `Rule 21.13
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_21_13.c>`_
> - Mandatory
> - Any value passed to a function in <ctype.h> shall be representable as
> an
> unsigned char or be the value EOF
> -
>
> + * - `Rule 21.14
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_21_14.c>`_
> + - Required
> + - The Standard Library function memcmp shall not be used to compare
> + null terminated strings
> + -
> +
> + * - `Rule 21.15
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_21_15.c>`_
> + - Required
> + - The pointer arguments to the Standard Library functions memcpy,
> + memmove and memcmp shall be pointers to qualified or unqualified
> + versions of compatible types
There is a trailing space at the end of this line
> + - void* arguments are allowed, see deviations.rst
> +
> + * - `Rule 21.16
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_21_16.c>`_
> + - Required
> + - The pointer arguments to the Standard Library function memcmp
> + shall point to either a pointer type, an essentially signed type,
> + an essentially unsigned type, an essentially Boolean type or an
> + essentially enum type
Also here.
> + -
> +
> * - `Rule 21.17
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_21_17.c>`_
> - Mandatory
> - Use of the string handling functions from <string.h> shall not result
> in
>
Apart from them, that I guess can be addressed on commit, it looks good to me,
I’ve also tested that the changes don’t break convert_misra_doc.py build.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
