Re: [PATCH] xen/spinlock: Adjust LOCK_DEBUG_INITVAL to placate MISRA

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 2024-04-10 21:35, Andrew Cooper wrote:
> Resolves an R7.2 violation.
Thanks, I was going to suggest the same change. This will resolve the 
failure of the CI MISRA analysis on GitLab.
Reviewed-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>

> Fixes: c286bb93d20c ("xen/spinlock: support higher number of cpus")
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: George Dunlap <George.Dunlap@xxxxxxxxxx>
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Juergen Gross <jgross@xxxxxxxx>
> CC: consulting@xxxxxxxxxxx <consulting@xxxxxxxxxxx>
> CC: Roberto Bagnara <roberto.bagnara@xxxxxxxxxxx>
> CC: Federico Serafini <federico.serafini@xxxxxxxxxxx>
> CC: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
>  xen/include/xen/spinlock.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/include/xen/spinlock.h b/xen/include/xen/spinlock.h
> index db00a24646bd..18793c5e29cb 100644
> --- a/xen/include/xen/spinlock.h
> +++ b/xen/include/xen/spinlock.h
> @@ -13,7 +13,7 @@
>  #ifdef CONFIG_DEBUG_LOCKS
>  union lock_debug {
>      uint32_t val;
> -#define LOCK_DEBUG_INITVAL 0xffffffff
> +#define LOCK_DEBUG_INITVAL 0xffffffffU
>      struct {
>          unsigned int cpu:SPINLOCK_CPU_BITS;
>  #define LOCK_DEBUG_PAD_BITS (30 - SPINLOCK_CPU_BITS)
>
> base-commit: 0e7ea8ca5fc9bce9248414f6aaf2dc861abd45d9
> prerequisite-patch-id: 8d06e56c5d8a52f1387e1f5a7fce6a94b8c4a1ed
> prerequisite-patch-id: 13355d26254b979c79de456c9a6ea6a9c639ba63
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)