[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 2/2] x86/Kconfig: Introduce CONFIG_{AMD,INTEL} and conditionalise ucode
On Wed, Apr 10, 2024 at 05:21:37PM +0100, Andrew Cooper wrote: > On 10/04/2024 4:14 pm, Roger Pau Monné wrote: > > On Thu, Oct 26, 2023 at 09:55:39PM +0100, Andrew Cooper wrote: > >> + > >> +config AMD > >> + bool "AMD" > >> + default y > >> + help > >> + Detection, tunings and quirks for AMD platforms. > >> + > >> + May be turned off in builds targetting other vendors. Otherwise, > >> + must be enabled for Xen to work suitably on AMD platforms. > >> + > >> +config INTEL > >> + bool "Intel" > >> + default y > >> + help > >> + Detection, tunings and quirks for Intel platforms. > >> + > >> + May be turned off in builds targetting other vendors. Otherwise, > >> + must be enabled for Xen to work suitably on Intel platforms. > > There seems to be a weird mix between hard tabs and spaces above. > > Naming is OK for me. > > Yeah. I already fixed those locally. With that fixed: Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx> > >> + > >> +endmenu > >> diff --git a/xen/arch/x86/cpu/microcode/Makefile > >> b/xen/arch/x86/cpu/microcode/Makefile > >> index aae235245b06..30d600544f45 100644 > >> --- a/xen/arch/x86/cpu/microcode/Makefile > >> +++ b/xen/arch/x86/cpu/microcode/Makefile > >> @@ -1,3 +1,3 @@ > >> -obj-y += amd.o > >> +obj-$(CONFIG_AMD) += amd.o > >> obj-y += core.o > >> -obj-y += intel.o > >> +obj-$(CONFIG_INTEL) += intel.o > >> diff --git a/xen/arch/x86/cpu/microcode/private.h > >> b/xen/arch/x86/cpu/microcode/private.h > >> index b58611e908aa..da556fe5060a 100644 > >> --- a/xen/arch/x86/cpu/microcode/private.h > >> +++ b/xen/arch/x86/cpu/microcode/private.h > >> @@ -70,7 +70,16 @@ struct microcode_ops { > >> * support available) and (not) ops->apply_microcode (i.e. read only). > >> * Otherwise, all hooks must be filled in. > >> */ > >> +#ifdef CONFIG_AMD > >> void ucode_probe_amd(struct microcode_ops *ops); > >> +#else > >> +static inline void ucode_probe_amd(struct microcode_ops *ops) {} > >> +#endif > >> + > >> +#ifdef CONFIG_INTEL > >> void ucode_probe_intel(struct microcode_ops *ops); > >> +#else > >> +static inline void ucode_probe_intel(struct microcode_ops *ops) {} > > This is stale now, and will need some updating to match what's in > > private.h. > > There's nothing state I can see. > > Patch 1 does significantly edit this vs what's currently in staging. Oh, sorry, I'm missed patch 1 then. Thanks, Roger.
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |