[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 03/13] xen/arm: Pass struct kernel_info parameter to make_resv_memory_node


  • To: Luca Fancellu <luca.fancellu@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Tue, 9 Apr 2024 15:18:10 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7vtqHpgt3NZn1fmP6u2Ngwt5fQom3+jGPQO3Uh/kIIU=; b=UtUYVBuBeohskDeKAT42S93nh3KyXbJxo0r5Br/cobCrNc7u+zmwaK0qKBxEY38mgWMXawqmsXw+e5Q86OYNVy/BR8xyLxte9OZwdXjwpobVC9fmrgWZZxBiqTNrdT1qrbplNp8/yEtxezBCG1Mo09ZXxYAVVPQSOBWw5TU9wvMm7/jkiN45HhqvGXgwpskXiHH6L+YGor+EfvmPtMEPTYybCO5ckOv70Pa1BXO1FN+Y2J25kHz04azyucM2CRbCXvO9E65C7vdHVVnjS8iBi8k3sXiaxWLyXR4bVHZhpfc56DiJUoMyfOt1Ezk4zOQWgOop3CpnxGdlJLNsTHohRw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qri4WpiHH2w9XRy75343UPVPFTZaD4O1+oRTHeF0uoGK78u4lPe8RGd0guxZKtl7zzEmpJWg5p/tz9Tu0gBdPNZ2ufHvOoUZ+6m6bHbu5IjQtLllUH1Gm8+l+/T7tN84FNMDQrvZToJGHt9U0Geo9zPLAuZI7gXHB+jDGQACYlKkZc4h+JsRUJjq6Fa+l66W0qCvb3e6zDaUp9AOgSJWrot+hybR/4baO3SXiZ/W8l//MJ2OgWAiw7EY7qKrJ/YyDeHkYuzZBd9quCcpYDiFFvhTiTlzzA9L69ZpNk0h/ggO17WAt2gy7Go5MyvhTQuhKvFCwKqCPMWYau4cQ/utIw==
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, "Volodymyr Babchuk" <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Tue, 09 Apr 2024 13:18:29 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Luca,

The title should be "xen/arm: Pass struct kernel_info parameter to 
make_{resv,shm}_memory_node
given that you're modifying both functions.

On 09/04/2024 13:45, Luca Fancellu wrote:
> 
> 
> The struct domain parameter is not used in make_resv_memory_node
> and in its called function make_shm_memory_node, so drop it from
> both function, also, take the occasion to pass directly
s/function/functions

> struct kernel_info, from which we can infer other parameter
s/parameter/parameters

> passed to the functions and drop them as well.
> 
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>

Other than that:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.