[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 1/3] xen/arm: Add imx8q{m,x} platform glue


  • To: John Ernberg <john.ernberg@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Tue, 9 Apr 2024 08:47:00 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=actia.se smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B/6V9brGLv+L902Oc5iArTSLIQFovT1+o6xN+dlJHww=; b=goxbVRgB3jtCBOQuJKsvZ46q7FEksyvGWGlXuMz/r1ddr2TFB5LX1LZIgGCKC8e1G9tW1AanNqaI3uiqlXGpy0qiiveVIOi0rBxhwuVhhg7DkEu+N+6mMAc/jdkPICEDxi3z6VtRkr91J+oONEsSQm4OjSXdPxP4Di4X8ZqoJtEPkgEKmVFiik+jENY9Jdf2mbbcjMVurjc2NA5nBIOFGHrkrckyy2C2SzdKGHMCF9tHr6pwcJqdStKHHYo366MgCJznPdYa+YALZonu79Z2KD3TMUmrdwrI2IBbzZ6ElhCAb2IOS3tqp4cFF154awJ3wyJ4oPNLhQjVeTXQvF0mkw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=adFEz8oCYdX/gJFocmFFuCIIV+ztkbZP3R7YkJr/u9yWbv8G+5t0nOjihDUUiUW5FA7MfdP8yVYea8zWJL0ACN3djTfmFM/gknu0tw240ZJn0XYocxnEeMAu2YC/uarcZuCnZk1FIgzJ0/kTWGluT6OE2OW4BWBikLuRrBaeRHEUYEAjhkrj1egIDbmotjui98/zfaszk/WjNOQs6lP8IYXWktzl1RdHortTLvRe0HrDJb0YNw2NzJimpKFsFo6o+Yob17zM7LG87PitqhH/XBz40Jrx8Qi5J46jiEvyc9VDPUPGq0y5CmO3+aIIjByM4TeH4wxE1mw3bHGXbuCQIA==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Peng Fan <peng.fan@xxxxxxx>, Jonas Blixt <jonas.blixt@xxxxxxxx>
  • Delivery-date: Tue, 09 Apr 2024 06:47:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi John,

On 08/04/2024 18:11, John Ernberg wrote:
> 
> 
> When using Linux for dom0 there are a bunch of drivers that need to do SMC
> SIP calls into the firmware to enable certain hardware bits like the
> watchdog.
> 
> Provide a basic platform glue that implements the needed SMC forwarding.
> 
> The format of these calls are as follows:
>  - reg 0: function ID
>  - reg 1: subfunction ID (when there's a subfunction)
>  remaining regs: args
> 
> For now we only allow Dom0 to make these calls as they are all managing
> hardware. There is no specification for these SIP calls, the IDs and names
> have been extracted from the upstream linux kernel and the vendor kernel.
> 
> Most of the SIP calls are only available for the iMX8M series of SoCs, so
> they are easy to reject and they need to be revisited when iMX8M series
> support is added.
Stale paragraph. Should be removed given that the driver targets only Q{M,XP}.

> 
> From the other calls we can reject CPUFREQ because Dom0 cannot make an
> informed decision regarding CPU frequency scaling, WAKEUP_SRC is to wake
> up from suspend, which Xen doesn't support at this time.
> 
> This leaves the TIME SIP, OTP SIPs, BUILDINFO SIP and TEMP ALARM SIP, which
> for now are allowed to Dom0.
BUILDINFO, TEMP ALARM are leftovers from previous revision.

> 
> NOTE: This code is based on code found in NXP Xen tree located here:
> https://github.com/nxp-imx/imx-xen/blob/lf-5.10.y_4.13/xen/arch/arm/platforms/imx8qm.c
> 
> Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> [jernberg: Add SIP call filtering]
> Signed-off-by: John Ernberg <john.ernberg@xxxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

The commit msg can be fixed on commit.

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.