[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] drivers: char: Drop useless suspend/resume stubs in Arm drivers
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Thu, 4 Apr 2024 10:13:00 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8p+hufjNbP9CzdogA87n7zb1gvgt6ELtuKNRLEjxoOk=; b=H5JaPzhpg/981i/FU50NUIy9JGg6NhwpJ9G4tt/XorGXfW0emddXfT4nxZPdkw9ia8MIiOktkuKpIKwEfGf0GuPoJMdU4SDdi1/Vc5XR95mVHnxD9z6hORle7/mhYyUAnR/orl5AliPEt3CxUDDDMNT0GxHKFR54y15KuzyXdLofsB1KBa09XHHtprp3C01HRF8jV2j8r5gCGjlGs4JDe5soQBKaAerxN4ojLtIO6ihIhVN1HMXpIIFoEC+bHnpjpLNiHl6u/ODsldP2PnQFDK9u7aUFBz5c/ykBdqwZZYtMxFcuA4MKGflzHRSaXzd4dF9v+ttxFaEvtvzzTC6lTQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZtBu2FM5TLweiZh90kOiJEDeKB2AMESQPBNXWkM7ENBiE5CPT4mditQJLm6/BkQPMiTV5CEplOlNsWTakPxGAMPUlWr4UhaRllxPTmFCRiKe7bonf35UtiNFPAiR3v4QxDRHeYYJXFN05v2RQB7oMczW5zZGvby2CQGpFinIUkc4+UU0WWaoOg8p+zMCd0dozikyEQ5EKmgoEa2nqgBfPB2SwqaV/Oh/w3IK92ScjBAsAetTE/h/3tPWazcG8guZg2vBgUD+fVahfekifbTg+CnIJSgR9e0cRLDgAJvUAEw4ewRfseu2qDEWe6zqjGMwc/gP0hp+XalOGqRsEhq9A==
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 04 Apr 2024 08:13:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jan,
On 04/04/2024 10:06, Jan Beulich wrote:
>
>
> On 04.04.2024 09:51, Michal Orzel wrote:
>> On Arm we don't use console_{suspend,resume} and the corresponding
>> stubs in serial drivers are being redundantly copied whenever a new
>> driver is added. Drop them as well as useless .endboot = NULL assignment.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>
> Since hook invocations are suitably guarded:
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
thanks
>
> However, from a Misra perspective more wants doing here if suspend/resume
> indeed isn't wanted / needed on Arm: console_{suspend,resume}() are
> unreachable there, and hence want hiding behind some (presumably)
> CONFIG_HAS_*. In turn the two hooks then would also want making conditional
> upon that option actually being selected by an architecture.
Yes, this will be handled in the future as part of the bigger activity to
compile out unused code.
~Michal
|
