[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 1/1] tools: init scripts: Add missing XENCONSOLED_ARGS variable
- To: Anthony PERARD <anthony.perard@xxxxxxxxx>
- From: Rafaël Kooi <rafael_andreas@xxxxxxxxxxx>
- Date: Mon, 25 Mar 2024 12:09:40 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=13O3vWjujuICVCMCryvtTZnNiI43HEuqbfs30qmqdho=; b=Fp36MXhnwMxPwzKuEwRma7H2cueaslms90GeIWCL+kBZjpBC8da2459ogXiAl+3hgUODNK0mSpIG5lmKLRwWfbY/qGtVCr4t0zO0rquGzKMMnHKIF/txoNZ0nqB2YU+EzAT9s9tYxB8LKhsDm+rbMpehK/XUaRsh6gn/20SYTBjKS89OQmc0gP5jebE3Nrrx8/u7Zk/7ssJIIDSrrJnbV6cylRLUvUvw+BcEuDE3OSyy162ePHOnCn6jDl2dPZsidLTIlYZ5pEy1fcO2wt8gBDGy77sDL0vQwFRRXH7rhDLvy21KgbLD9JR4I44UJm3//jPUjs4d85TllWIKJ6okxw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TKip9s3J2Rh0mpKY/LbKF9mUyt5avRHw290Fnpe93BVFsEpe/Trrk2h8PAsQpEojWBKtDPibiAWO2Sy2XHhLxAxT79S4FbPbEyQaZZbM2G6NKdYjCxLJMUpo70I9UkAGdaOt7RdQOQ7PrMdoWo/SRRkpyE4McZPMfWWCU+8+Qn404WIdULBaJYzurQBQ2YrM9p/XtuKB5NoT2EbM9UZU3xITh5wU+H4E0NLXe8XUbPZSFTe3qvR6og2HpDsvJ2vpJPJoKTuPbDJewZqKmWgVU/Dccwx69PTeqP8C9W9FGbEDD0kTUeH9rqsfBGOwFt9BGYzo3EjJIiniDGQIUJLZLw==
- Autocrypt: addr=rafael_andreas@xxxxxxxxxxx; keydata= xjMEZHDtHhYJKwYBBAHaRw8BAQdA4C7O72UZHQbhHNm1BUkAM/7+KQKN3tupyuGVGyj2dIHN KVJhZmHDq2wgS29vaSA8cmFmYWVsX2FuZHJlYXNAaG90bWFpbC5jb20+wo8EExYIADcWIQTv ioHnE84MxV6adj/iFi3SALEToAUCZHDtHgUJA8JnAAIbAwQLCQgHBRUICQoLBRYCAwEAAAoJ EOIWLdIAsROgP80BAKeJdh3YQ5l3gxGp8R9wIvN9Ac3vsMfy8I4kZ6TXksLKAP9vLRV4G3yw z7/seKhWc27Jjl4uI/+lIWhWaWrUYZmjAM44BGRw7R8SCisGAQQBl1UBBQEBB0DE61lbAezY NhOlHgxdZ9V4klIhSajeU50O8wHIPQnCLgMBCAfCfgQYFggAJhYhBO+KgecTzgzFXpp2P+IW LdIAsROgBQJkcO0fBQkDwmcAAhsMAAoJEOIWLdIAsROghHgBANU4dj+WnuSaWemAHVkjERJg m0FQpmZzNI8hdolS3gYdAP9zGK65ilpHMDj4pGvfALabruZA4NPJYxSqeamHvOuhBA==
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 25 Mar 2024 11:09:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25/03/2024 11:32, Anthony PERARD wrote:
On Wed, Mar 20, 2024 at 08:48:33AM +0100, Rafaël Kooi wrote:
The systemd xenconsoled.service uses the XENCONSOLED_ARGS variable, but
it was missing from the xencommons file.
Actually, I'm tempted to go the other way and remove XENCONSOLED_ARGS
from the systemd's service file. In the other service files (openrc,
sysvinit) for Linux/FreeBSD/NetBSD, XENCONSOLED_ARGS is simply used to
construct the command line for `xenconsoled`. For the Linux one, if you
set XENCONSOLED_TRACE, XENCONSOLED_ARGS from xencommons won't be used.
I assume you mean the OpenRC/SysV init script?
> On the other end, with systemd, it is very easy to modified a service
file, to add an argument to the command line. So removing
XENCONSOLED_ARGS would make more sense. But some user might have notice
it exist and start using it, so it's probably too late to remove it.>
So overall, I don't think it's a good idea to advertise
XENCONSOLED_ARGS, first because it's kind of useless for systemd, and
second because it's broken for "tools/hotplug/Linux/init.d/xencommons.in"
Side note: looks like on my test machine I've used systemd instead of
editing /etc/default/xencommons to change XENCONSOLED_TRACE, so there's
really no need for "xencommons" config file on systemd:
# /etc/systemd/system/xenconsoled.service.d/trace_all.conf
[Service]
Environment=XENCONSOLED_TRACE=all
That "xencommons" config file is just there to be compatible with both
init system.
Cheers,
Makes sense. To be honest I don't even know what arguments one would pass
to xenconsoled other than setting the log level to begin with. I would
assume this to be a niche enough use case where very few users would be
affected if we do decided to remove the variable. Maybe we could opt to
advertise it as something that we will be removing in a later release?
Maybe either through an "ExecStartPre" message, or by updating the comment
in xencommons.
Thanks,
Rafaël Kooi
|
