Re: [PATCH 2/7] xen/credit2: Clean up trace handling

[George Dunlap <george.dunlap@xxxxxxxxx>]

On Wed, Mar 20, 2024 at 12:16 PM George Dunlap <george.dunlap@xxxxxxxxx> wrote:
>
> On Mon, Mar 18, 2024 at 4:36 PM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> 
> wrote:
> >
> > There is no need for bitfields anywhere - use more sensible types.  There is
> > also no need to cast 'd' to (unsigned char *) before passing it to a 
> > function
> > taking void *.  Switch to new trace_time() API.
> >
> > No functional change.
>
> Hey Andrew -- overall changes look great, thanks for doing this very
> detailed work.

For my own posterity later:

I've done a close review of the rest of the patch and didn't see any
issues other than the loss of sign in a handful of cases.

 -George