Re: [PATCH v5] x86/PoD: tie together P2M update and increment of entry count

[George Dunlap <george.dunlap@xxxxxxxxx>]

On Tue, Mar 19, 2024 at 1:22 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> When not holding the PoD lock across the entire region covering P2M
> update and stats update, the entry count - if to be incorrect at all -
> should indicate too large a value in preference to a too small one, to
> avoid functions bailing early when they find the count is zero. However,
> instead of moving the increment ahead (and adjust back upon failure),
> extend the PoD-locked region.
>
> Fixes: 99af3cd40b6e ("x86/mm: Rework locking in the PoD layer")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Oh!  Thanks for doing this -- I hadn't responded because I wasn't sure
whether I was bikeshedding, and then it sort of fell off my radar.  At
any rate:

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxx>