[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/3] Revert "xen/x86: bzImage parse kernel_alignment"


  • To: Jan Beulich <jbeulich@xxxxxxxx>
  • From: Jason Andryuk <jason.andryuk@xxxxxxx>
  • Date: Thu, 14 Mar 2024 09:01:26 -0400
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2DHtA8NVvw/hqNNL6V0lTnnxoGT8K7/zE/1b3H+04ic=; b=CRZXeifnvilGo6pCpBVYyonYIlZ/witq4ow1K2dLgRYGfdHSteBapBPNWPjw+D9FvuxBib1Vt/jB1jbWd1Nhtd48cGgghcn7d4d68u6g13nT3jZRu/vscQvuxYZJV0GNeeOdJV0bmgqFhYsaKzMoe+XTGOTzxG5zXSKdZ7rTXJNi585XNFfe7UUxWrYxC6jqrfoZe/bGYa0jfNQM88Czqc9ZsUamTppY4MZ2032qvETjJRYXEaXIq4qHuUDA9B9YAyBvX6rWQSLUAJUZDHoQuirGiNQzPU4i3cH9ms9N/SSftyHKasRyvjhMnDfvepYlCbjURT8Qt2jiy6hZMcOF4A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GdQTB/btjcGaMAVbp0lABPRf0/PeVeDJDJ9yOg3zu2ijum8tOS0c0cpqAvVNC1UJvSsqBDEYGjfseZDpNkw00Ne9E5POXxcgW05b0OB7TuWNre6gSlYHKTuRQwikcl4jHhIaYJl72Cup645OANXmKmo/5W/PFrIMBgukBtJVLLozBj4AHpZ0AeRZzYEKms0t1pAHhab7tPbkylpDlfOLkiaCP3VSe2R6IYoPEcZ7H7lNE6RBENy7mmZz9x0TjgaB+LkfA0+VULeVhrPvQkH2RzXZVIZmLvELEd8JGsE03YskHwF19CJePt00gKu/t7AaCBQFMD3BpjBMz+hkfu680g==
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Thu, 14 Mar 2024 13:01:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 2024-03-14 03:11, Jan Beulich wrote:
On 13.03.2024 20:30, Jason Andryuk wrote:
A new ELF note will specify the alignment for a relocatable PVH kernel.
ELF notes are suitable for vmlinux and other ELF files, so this
Linux-specific bzImage parsing in unnecessary.

Hmm, shouldn't the order of attempts to figure the alignment be ELF note,
ELF header, and then 2Mb?

This patch series makes Xen only relocate when the ELF Note is present. Linux PVH entry points today are not relocatable, so that needs to be specified some way. This new note also includes the alignment, so there is no need to try other means of obtaining the alignment.

Also, the ELF header values didn't change with CONFIG_PHYSICAL_ALIGN, so that didn't seem reliable.

Thanks,
Jason



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.