Re: [OSSTEST PATCH] ap-common: Switch to Linux 6.1 by default on x86 + drop dom0 i386

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On Tue, Mar 12, 2024 at 05:19:46PM +0000, Anthony PERARD wrote:
> On Mon, Mar 11, 2024 at 06:27:52PM +0100, Roger Pau Monné wrote:
> > On Wed, Mar 06, 2024 at 11:47:41AM +0000, Anthony PERARD wrote:
> > > Gone, but replaced by a new test-amd64-amd64-*:
> > > - test-amd64-i386-libvirt-raw
> > > - test-amd64-i386-xl-vhd
> > > 
> > > Some test-amd64-amd64-* are also changed:
> > > - test-amd64-amd64-libvirt-vhd
> > > - test-amd64-amd64-qemuu-freebsd11-amd64
> > > - test-amd64-amd64-qemuu-freebsd12-amd64
> > > - test-amd64-amd64-xl-qcow2
> > > + test-amd64-amd64-freebsd11-amd64
> > > + test-amd64-amd64-freebsd12-amd64
> > > + test-amd64-amd64-libvirt-qcow2
> > > + test-amd64-amd64-libvirt-raw
> > > + test-amd64-amd64-xl-vhd
> > 
> > Is this purely a name change, or there's some kind of functional
> > change?
> 
> For test-amd64-amd64-qemuu-freebsd1{1,2}-amd64, it looks like the
> "-qemuu" is a bug. The freebsd jobs shouldn't have used $qemuu_suffix,
> as it doesn't use $qemuu_runvar. So I'm guessing $qemuu_suffix was just
> the value left from a previous call of test_matrix_do_one() with
> dom0arch==i386. The new name is already used by "linux-linus" branch.

FTAOD, could you mention this in the commit message?

FreeBSD doesn't use `$qemuu_runvar` because it was always using QEMU
upstream (when the FreeBSD test was added we decided to only test with
QEMU upstream).  So there's indeed no `-qemut` variant, but by
dropping the -qemuu prefix it could be confused with a PV guest
based test.

> As for the few changes in {xl,libvirt}-{raw,vhd,qcow2} tests, this is
> because of
> - f536e834f673 ("make-flight: Trim the matrix of disk format flights")
> - 5c70735f177f ("fmtarches: Use dom0arches, not hardcoded arch list")

Probably a dummy question, but why haven't those commits changed the
output of make-flight earlier?  I'm fine with the change, but I don't
really get why we are seeing it only now.

>    > It's not ideal because it means tests jumping about across arches and
>    > might let regressions go through but it's better than just dropping
>    > them, and doing a better approach is complex.
> 
> So, for those, yes, it's different tests. It adds one "-raw" test, and
> otherwise changes the toolstack used for the two other disk formats.
> 
> > I'm mostly worried whether this could lead to regressions getting in
> > as osstest would detect those jobs as new instead of inheriting from
> > the previous jobs.  Also the "History for test ..." won't link to jobs
> > prior to the rename?
> 
> Well, those tests are already in the "linux-linus" branch and the new
> "linux-6.1" branch, so we can already check manually if there's a
> regression or not. So if they pass in linux-6.1, regression will be
> detected, at least in the linux branch.
> 
> The rename of the freebsd jobs is unfortunate, but at least, it's going
> to be the correct name, instead of having a spurious "-qemuu" suffix.
> 
> As for "history of tests " pages, no I don't think we can easly link to
> to the previous job name. But that only apply to both freebsd* jobs.
> 
> We could keep the -qemuu in freebsd* jobs even if it's misleading to
> someone who know what it should mean, that would keep the job name to
> all branches and rename it in "linux-linus" branch. I don't know which
> one is better.
> 
> > I guess I'm confused about what causes the qemuu to be dropped from
> > the job names above.
> 
> It just shell script having variable been global by default.

Thanks for the clarification.

Roger.