Re: [PATCH v9 1/7] automation: introduce fixed randconfig for RISC-V

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 7 Mar 2024, Oleksii wrote:
> Hello Doug and Stefano,
> 
> While Michal has reviewed this patch, I understand that I still need
> your Acked-by.
> 
> Could you please take a moment to review the patch?
> 
> Thanks in advance.

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>



> ~ Oleksii
> 
> On Fri, 2024-02-16 at 13:39 +0100, Oleksii Kurochko wrote:
> > This patch introduces the anchor riscv-fixed-randconfig,
> > which includes all configurations that should be disabled for
> > randconfig builds.
> > 
> > Suggested-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > ---
> > The patch were introduced after discussion in a topic:
> >  
> > https://lore.kernel.org/xen-devel/cover.1701966261.git.oleksii.kurochko@xxxxxxxxx
> > /
> > ---
> > Changes in V9:
> >  - add '|' symbol after EXTRA_FIXED_RANDCONFIG to make variables in
> > EXTRA_FIXED_RANDCONFIG
> >    be separated by new line.
> >  - instead of introduction of new file for riscv-fixed-randconfig,
> > introduce an anchor
> >    inside build.yaml
> > ---
> > Changes in V8:
> >  - Nothing changed. Only rebase
> > ---
> > Changes in V7:
> >  - Nothing changed. Only rebase
> > ---
> > Changes in V6:
> >  - The patch was introduced in this version of patch series.
> > ---
> >  automation/gitlab-ci/build.yaml | 14 ++++++++++----
> >  1 file changed, 10 insertions(+), 4 deletions(-)
> > 
> > diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-
> > ci/build.yaml
> > index 6d2cb18b88..aac29ee13a 100644
> > --- a/automation/gitlab-ci/build.yaml
> > +++ b/automation/gitlab-ci/build.yaml
> > @@ -512,6 +512,14 @@ alpine-3.18-gcc-debug-arm64-boot-cpupools:
> >        CONFIG_BOOT_TIME_CPUPOOLS=y
> >  
> >  # RISC-V 64 cross-build
> > +.riscv-fixed-randconfig:
> > +  variables: &riscv-fixed-randconfig
> > +    EXTRA_FIXED_RANDCONFIG: |
> > +      CONFIG_COVERAGE=n
> > +      CONFIG_EXPERT=y
> > +      CONFIG_GRANT_TABLE=n
> > +      CONFIG_MEM_ACCESS=n
> > +
> >  archlinux-current-gcc-riscv64:
> >    extends: .gcc-riscv64-cross-build
> >    variables:
> > @@ -532,8 +540,7 @@ archlinux-current-gcc-riscv64-randconfig:
> >      CONTAINER: archlinux:current-riscv64
> >      KBUILD_DEFCONFIG: tiny64_defconfig
> >      RANDCONFIG: y
> > -    EXTRA_FIXED_RANDCONFIG:
> > -      CONFIG_COVERAGE=n
> > +    <<: *riscv-fixed-randconfig
> >  
> >  archlinux-current-gcc-riscv64-debug-randconfig:
> >    extends: .gcc-riscv64-cross-build-debug
> > @@ -541,8 +548,7 @@ archlinux-current-gcc-riscv64-debug-randconfig:
> >      CONTAINER: archlinux:current-riscv64
> >      KBUILD_DEFCONFIG: tiny64_defconfig
> >      RANDCONFIG: y
> > -    EXTRA_FIXED_RANDCONFIG:
> > -      CONFIG_COVERAGE=n
> > +    <<: *riscv-fixed-randconfig
> >  
> >  # Power cross-build
> >  debian-bullseye-gcc-ppc64le:
>