[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] xen/arm: Fix arm32 build failure when early printk is enabled


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Wed, 28 Feb 2024 11:35:55 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UJETay2uUVAJ5SihwmOLSlS2wrmi7o0ZhePbQ5L7+O4=; b=W+Yq9sLfkSpVfHFkqxzhDxcQ51REd81eE2zHq15U26rwxuc5441TUnIfURRQYQGxMSRQ1rTLrN2zgDTWpBKDB8UN3B6SAKnmcb+NQlE1jeSa3zoZ1rNakvc4C3sXT1VRIDpanPiZKREqBF4FRDBemPo4OEHT3LSBiI9GJr45Tkq+lXOys6yVvZs9EQ2exQD9Zkgs+D2/6Ux4mX2XoEVixcfvITG+zeZPZlu+W0oyeDbNiF+klIjzNZeGjjgCHLajzVAAYwVUeTPsA5xeI4agC1y4cp7lekPmbuaIKgLh1pjaM8vqcWWerNb/N9pbu+HCnVPVfSYd0v7/ABhcWDZirQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PQvhUsjMCn5OFne3T09KQ6Gu9y5CLQeYkWHWAlyTyWk9hv2i0MpwWtDBniQlqzniPElmLqrNxv5/CUD1nD2j8K5ting89EmBzisswyjnQmYUfDHeWzv2ceIjCsnrbeZoz/gwZTh+o91IxnGCmGZZvVIrgiS0YYeZCeOEycebOr2n+qy11jYShU5IdIiNzph6kTgbCLZa0bk4XwBUBNfSij60RghMBN6oMoHJ6UFCTxVYA5/eE08tN3h1ArLi/Wy9Yh02PzGpFQInFGOwuN9f2l6RFkrEP2SoEMTYfazebOXgWd2x7wda2VYHyXK7QnoCLheZfdaym2xCdJFFvnBpEQ==
  • Cc: Michal Orzel <michal.orzel@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
  • Delivery-date: Wed, 28 Feb 2024 10:36:10 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Commit 0441c3acc7e9 forgot to rename FIXMAP_CONSOLE to FIX_CONSOLE in
TEMPORARY_EARLY_UART_VIRTUAL_ADDRESS macro. This results in a build
failure on arm32, when early printk is enabled:
arch/arm/arm32/mmu/head.S:311: Error: invalid operands (*UND* and *ABS* 
sections) for `*'

Fixes: 0441c3acc7e9 ("xen/arm: fixmap: Rename the fixmap slots to follow the 
x86 convention")
Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
---
 xen/arch/arm/include/asm/early_printk.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/early_printk.h 
b/xen/arch/arm/include/asm/early_printk.h
index f444e89a8638..46a5e562dd83 100644
--- a/xen/arch/arm/include/asm/early_printk.h
+++ b/xen/arch/arm/include/asm/early_printk.h
@@ -20,7 +20,7 @@
     (FIXMAP_ADDR(FIX_CONSOLE) + (CONFIG_EARLY_UART_BASE_ADDRESS & ~PAGE_MASK))
 
 #define TEMPORARY_EARLY_UART_VIRTUAL_ADDRESS \
-    (TEMPORARY_FIXMAP_ADDR(FIXMAP_CONSOLE) + (CONFIG_EARLY_UART_BASE_ADDRESS & 
~PAGE_MASK))
+    (TEMPORARY_FIXMAP_ADDR(FIX_CONSOLE) + (CONFIG_EARLY_UART_BASE_ADDRESS & 
~PAGE_MASK))
 
 #endif /* !CONFIG_EARLY_PRINTK */
 
-- 
2.25.1




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.