[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: make sure build fails when running kconfig fails


  • To: Anthony PERARD <anthony.perard@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 20 Feb 2024 13:20:16 +0100
  • Autocrypt: addr=jbeulich@xxxxxxxx; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 20 Feb 2024 12:20:20 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 20.02.2024 12:18, Anthony PERARD wrote:
> On Tue, Feb 20, 2024 at 09:43:56AM +0100, Jan Beulich wrote:
>> Because of using "-include", failure to (re)build auto.conf (with
>> auto.conf.cmd produced as a secondary target) won't stop make from
>> continuing the build. Arrange for it being possible to drop the - from
>> Rules.mk, requiring that the include be skipped for tools-only targets.
>> Note that relying on the inclusion in those cases wouldn't be correct
>> anyway, as it might be a stale file (yet to be rebuilt) which would be
>> included, while during initial build, the file would be absent
>> altogether.
>>
>> Fixes: 8d4c17a90b0a ("xen/build: silence make warnings about missing 
>> auto.conf*")
>> Reported-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Just to make sure, this patch is a workaround to a harmless bug in older
> version of GNU Make which print spurious error messages, and said bug as
> been fixed in GNU Make 4.2, right? Bug report:
> 
>     bug #102: Make prints an incorrect error for missing includes
>     https://savannah.gnu.org/bugs/?func=detailitem&item_id=102

Assuming you mean the change referenced in Fixes: - yes, that's my
understanding. (Whether the referenced make bug is the one I can't tell,
though. But it looks like it is.)

>> --- a/xen/Makefile
>> +++ b/xen/Makefile
>> @@ -375,6 +375,7 @@ $(KCONFIG_CONFIG): tools_fixdep
>>  # This exploits the 'multi-target pattern rule' trick.
>>  # The syncconfig should be executed only once to make all the targets.
>>  include/config/%.conf include/config/%.conf.cmd: $(KCONFIG_CONFIG)
>> +    $(Q)rm -f include/config/$*.conf
> 
> Maybe this should say "include/config/auto.conf" instead of using "$*".
> "syncconfig" is going to generate "auto.conf" and not "$*.conf". And it
> would make easier to find the "rm" command via "grep".

Generally I advocate for using $* wherever possible in pattern rules. If,
however, replacing that is the only way to get an ack for this change, then
I would (hesitantly) do so.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.