[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Make hwdom vUART optional feature
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Thu, 15 Feb 2024 15:49:27 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8WCZ1M3VC/1KYKTG9M3PBbed7brqmkEF+fhFYWwZpf0=; b=i6o20O7YdLX8WTsxuSzJq3IxBPDkppPNocGt3AF5cBZhBAr9gtZ2ZtyXMeT3ZqaaWFcPaTJF/2ZU0ncbuiffFhWbef6STL9jidH/laYpaKaGCR7R3tTMMq4RqwzxewuGjJbA6s5DUFpG//pt10Lm/v88tDtAjwk6ueyd3ILJBb6dec4wCDFSJ82Y5fHbjGP/RBosEe/ato1PA9eFxkJYiFFF0YPgDzpVpEcyTIrTQH0KkU/cvkkkfs50b2v/Evou/Nicfidc66okylI7A5ZV1c4NxwOW/liLhjYdftqYIAFqfwcOVWRkUSazMk9+5qNaUfiS6b09clILaYpJy/e+yQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8WCZ1M3VC/1KYKTG9M3PBbed7brqmkEF+fhFYWwZpf0=; b=c7zWhiFaLoAimoxhRner2uu3OMN9s0O4bdAboTHcQD0N1y6L9atMiuJ3rF4oPeKVnxxV4FfJV01vw2NJaSAtySZ6snf0/XrFETkOOr5vX2YYq5ylgefvC7253OhLdAXKOcmMJK7ninqAskqegsSNm0XWTH3xdTubgAnt2ksnOQ6wHVn7h/YPOKne5K7Re0rUf13KwEwT4ADR8V0F+xBOxR6G3mVjWJDB6ReMvnNGo0XyJBIC9dhqK/boiHOuA58MORa3P3asDdLLb5m9rNG1r3KhtrboFwLpvjXEBkBr6PxwDfbrlPiG5maz+B3Wh5H0225+ijE5XlYtYZqImm8E4A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UmkV5bZEB3zMhJ2mrLRgAQAwmsoFjzKdieAHydW0oAVzWscut0P0n25vR4+PwEyc16rW8B+ny0IYX/fWn1cDCNH1hVz5g/zEwgegEc9i0Wn2nXMkAxSyfpznTDc/4Czhseu0HZZxd4mpA6RFPnAWH7DM5s88pig48kXXfyxvru0x5yZthTl8v4mBXYWCOYaji7v9HVR6II4RRH7JhdE6wcGk/xRwgGMzoPgDU0eCdf5tsQ4wUrrS/JxcrniT2GeA2Igbq9rhDb1nblGGe1IvmUV7nsxhCvOaQ4MK3/QMsbwy8jx0QbcoLoK7Yu9up3rlwqE64jqYgvPzIGt/T2g5EA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iXVEGdfc6jyC/7NsxXStFl9jY49dFPo/naMFxKWwBdTz5ttamhZh2J0x4MaaFpB3u7apunAPS8d+ZxDBLBjQggPQ0b7OuRvwy7i06miXudOJkP9HsMxkBxyh8URXDySqHGQPz7khIVw++ZLXPpbB+K4PKtL4+4ofekl8wyRWxLm4on3yIHOI8RilmtovwDmHaVvfXSoU96wY0MypXki+W80OMu1yGS62bznpIFhnKgq6cM3NwIq5rLSZDNVcVni7YNMxU1s+JjfAe2adnXqqjba17J2/Z4ZLONxVE0EwM03b40IpugB4g+gMKKUoHn+UQFV1adeMbJkP2VDUMdxofQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Thu, 15 Feb 2024 15:49:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaYBz49ii/8gxOY0aM41gWsHqs/bELjNUA
- Thread-topic: [PATCH] xen/arm: Make hwdom vUART optional feature
> On 15 Feb 2024, at 14:39, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> At the moment, the hardware domain vUART is always compiled in. In the
> spirit of fine granular configuration, make it optional so that the
> feature can be disabled if not needed. This UART is not exposed (e.g.
> via device tree) to a domain and is mostly used to support special use
> cases like Linux early printk, prints from the decompressor code, etc.
>
> Introduce Kconfig option CONFIG_HWDOM_VUART, enabled by default (to keep
> the current behavior) and use it to protect the vUART related code.
> Provide stubs for domain_vuart_{init,free}() in case the feature is
> disabled. Take the opportunity to add a struct domain forward declaration
> to vuart.h, so that the header is self contained.
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> ---
Hi Michal,
Looks good to me, I’ve also tested with and without vuart on qemu arm64.
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|