Re: [PATCH v5 16/22] tools/xl: support new 9pfs backend xen_9pfsd

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Feb 08, 2024 at 05:55:40PM +0100, Juergen Gross wrote:
> Add support for the new 9pfs backend "xen_9pfsd". For this backend type
> the tag defaults to "Xen" and the host side path to
> "/var/log/xen/guests/<dom-name>".
> 
> Do most of the default settings in libxl. Unfortunately the default
> path can't easily be set in libxl, as the domain name isn't available
> in the related 9pfs specific function.

It might be possible to do that in libxl__domain_config_setdefault(), or
maybe in initiate_domain_create(), but I guess that's fine to set the
default path in xl. Users of libxl might want to have a different
default path.

> Settings the defaults in libxl requires to move the sanity checking
> of 9pfs parameters from xl to libxl, too.
> 
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> ---
> V2:
> - test max_files and max_open_files, too (Jason Andryuk)
> V4:
> - fix man page to use the "xen_9pfsd" type due to idl limitation
>   (Jason Andryuk)
> - set (most of) the defaults in libxl (Anthony Perard)

Patch looks good to me now:
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD