Re: [PATCH] tools/ocaml: Add missing vmtrace_buf_kb field

[Christian Lindig <christian.lindig@xxxxxxxxx>]

> On 7 Feb 2024, at 22:04, Petr Beneš <w1benny@xxxxxxxxx> wrote:
> 
> 
> Add the missing `vmtrace_buf_kb` field to the OCaml bindings to match the
> vm.cfg configuration, correcting an oversight from its initial introduction.
> 
> Signed-off-by: Petr Beneš <w1benny@xxxxxxxxx>

Acked-by: Christian Lindig <christian.lindig@xxxxxxxxx>

This looks correct from an OCaml perspective. Why was the new field added in 
the middle of the record type domctl_create_config and thus forcing changes to 
the index of fields coming later in the record versus just appending the new 
field to the record type?

The critical bit is using the correct type in "Int32_val(VAL_VMTRACE_BUF_KB)” 
that matches the type "vmtrace_buf_kb: int32;” - which it does.

—- C