[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v13 01/14] vpci: use per-domain PCI lock to protect vpci structure
- To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>
- Date: Tue, 6 Feb 2024 10:43:54 -0500
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uW+dyA4uXT1vZWzti66UCaFqrNJtNdR9zsDv9KTJ3eY=; b=BhNCUUVKoS+Yyw/FtzcoLnYMEaY6dU6PelaFx5U0TZ6bjCbNakzKxfaOFpkxBKQIp2Rocdb611a5pHs4uDLcJd/jUlrr3zu4/ta7put/gIYWZ08U+cSzntftFNveMZusI3Q5M8XwTI48iuTmLnItUgyKdz+aBmSfaKDni6uPAwTbemvAilq8hohKeaX5fN2TQk6mAkGhmGeeBl/2FxdMXxkEjtlwHuD9khQhXUqk9SsIHncZVKI53u4YnLynHBOS9ji3UDIBpK36ETA81vDwUWTUt0L9sGA9GWysv3wQwYUnEBLJipFH+M/QSzVoqZBEXkgcDlorHyCrc4aAInBg0g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IwHKLgJBvmpC0YzBpPTi+hwV828OIdVdPvAIkm6CN8tl/caH9cQrdhbIFpeb2ngsVDvR4rsMYUeobuPcyNSHjEM6GgtbtPbKMwPoBY+jou2zuX2DXqt+OgOnGyLMhPkK/hAdCIQlWxgzRsCISuEgcAjb2kHf7dEJZkXG3bHUzjwyoz/KfRD8Pg1ATsk6dRSqmWh9U0w2aIecdaClE+P8D5Tg3T1sf2gMXsy+g3Wr0qevQXrYrGc1Xr8wjPBJZMjgGzf7UyeLz9aNJBjLLceggJ3dVlgsiv5chUFYPCeQ/gPNKMTCAMCTlCxbOS3AmJE0wKkXNBqivJsfdUTA9GbwgA==
- Cc: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>
- Delivery-date: Tue, 06 Feb 2024 15:44:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2/2/24 16:33, Stewart Hildebrand wrote:
> ---
> Changes in v13:
> - hold off adding Roger's R-b tag even though it was provided on v12.2
> - use a wrapper construct to ease readability of odd-looking ASSERTs
> - new placement of ASSERT in __pci_enable_msix(), __pci_enable_msi(),
> and pci_enable_msi(). Rearrange/add pdev NULL check.
> - expand commit description with details about using either
> pcidevs_lock() or d->pci_lock
>
> Changes in v12.2:
> - drop Roger's R-b
> - drop both locks on error paths in vpci_msix_arch_print()
> - add another ASSERT in vpci_msix_arch_print(), to enforce the
> expectation both locks are held before calling vpci_msix_arch_print()
> - move pdev_done label in vpci_dump_msi()
> - update comments in vpci_dump_msi() to say locks (plural)
Here's a patchew link to show just the diff-of-diff from v12.2 (where
Roger had given a R-b) to v13.
https://patchew.org/Xen/20240115194309.45683-1-stewart.hildebrand@xxxxxxx/diff/20240202213321.1920347-2-stewart.hildebrand@xxxxxxx/
|
