Re: [PATCH v2 (resend) 02/27] x86/setup: Move vm_init() before acpi calls

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 25 Jan 2024, Jan Beulich wrote:
> On 16.01.2024 20:25, Elias El Yandouzi wrote:
> > From: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > After the direct map removal, pages from the boot allocator are not
> > going to be mapped in the direct map. Although we have map_domain_page,
> > they are ephemeral and are less helpful for mappings that are more than a
> > page, so we want a mechanism to globally map a range of pages, which is
> > what vmap is for. Therefore, we bring vm_init into early boot stage.
> > 
> > To allow vmap to be initialised and used in early boot, we need to
> > modify vmap to receive pages from the boot allocator during early boot
> > stage.
> > 
> > Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > Signed-off-by: David Woodhouse <dwmw2@xxxxxxxxxx>
> > Signed-off-by: Hongyan Xia <hongyxia@xxxxxxxxxx>
> > Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
> > Signed-off-by: Elias El Yandouzi <eliasely@xxxxxxxxxx>
> 
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> albeit ...
> 
> > --- a/xen/arch/arm/setup.c
> > +++ b/xen/arch/arm/setup.c
> > @@ -748,6 +748,8 @@ void asmlinkage __init start_xen(unsigned long 
> > boot_phys_offset,
> >  
> >      setup_mm();
> >  
> > +    vm_init();
> > +
> >      /* Parse the ACPI tables for possible boot-time configuration */
> >      acpi_boot_table_init();
> >  
> > @@ -759,8 +761,6 @@ void asmlinkage __init start_xen(unsigned long 
> > boot_phys_offset,
> >       */
> >      system_state = SYS_STATE_boot;
> >  
> > -    vm_init();
> > -
> >      if ( acpi_disabled )
> >      {
> >          printk("Booting using Device Tree\n");
> 
> ... with this change the title claiming x86 isn't quite right. Hopefully
> Arm folks will spot the need for an ack there nevertheless.

Acked-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>