[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: Ping: Ping: [PATCH] Argo: drop meaningless mfn_valid() check
On Mon, Feb 5, 2024 at 4:17 AM Jan Beulich <jbeulich@xxxxxxxx> wrote: > > On 04.01.2024 09:12, Jan Beulich wrote: > > On 23.12.2023 22:35, Christopher Clark wrote: > >> On Sat, Dec 23, 2023 at 12:47 PM Christopher Clark > >> <christopher.w.clark@xxxxxxxxx> wrote: > >>> > >>> On Sun, Dec 17, 2023 at 11:55 PM Jan Beulich <jbeulich@xxxxxxxx> wrote: > >>>> > >>>> Christopher, > >>>> > >>>> On 27.11.2023 14:55, Jan Beulich wrote: > >>>>> Holding a valid struct page_info * in hands already means the referenced > >>>>> MFN is valid; there's no need to check that again. Convert the checking > >>>>> logic to a switch(), to help keeping the extra (and questionable) x86- > >>>>> only check in somewhat tidy shape. > >>>>> > >>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> > >>> > >>> Reviewed-by: Christopher Clark <christopher.w.clark@xxxxxxxxx> > >> > >> I'd like to hold off on this just yet, sorry -- the change does look > >> ok as far as a transform being applied the prior logic and the > >> necessity of the check, but with it applied, it's not obvious that it > >> handles all the page types as best that it could there, so I'd like to > >> look at this (and the previously submitted patch again) please. > > > > I'm puzzled: This patch merely removes a pointless check. Whatever is > > lacking with it in place will have been lacking before. Also can you > > please give a rough estimate towards when you'll be getting back on > > this, or ideally on both patches? > > Another month later: I'll give it this week, and without hearing back > I'll commit what there is some time next week, with the R-b you provided. Sorry for the slow communication. I'm not unaware of this but it has been difficult to provide an update on when I will be able to give it the appropriate attention. I understand that you'd appreciate a response before next week, so I'll aim for that. thanks, Christopher
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |