[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 07/15] xen/arm: add support for cache coloring configuration via device-tree


  • To: Jan Beulich <jbeulich@xxxxxxxx>, Carlo Nonato <carlo.nonato@xxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Mon, 5 Feb 2024 11:08:04 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zt3qmdHsgtzsLYbX8ogEy8B8gjkmIE8jC21cSZOWJ1o=; b=XXIJbLAEFFwpsCfUoZHB7pkCyWXxHln5RpBgBMh6sh96JT7t7IVIiOkjv+qYLV9hIpqjfKpVeBAgRyVVUAzo5wsskrJCgKzCsfw4Gmg9+GP6Vum/8g+V7royyo1Q80DaMNGOGqPuoOkJpjzh8qyMKA4lawUToGwXLoo94ENfs0N8cpcC8NAfUqRORKKOxf2QtvwKHbpZ+dIHr7nMYwuRAqnAGfK0Lo8fc+n67JvbqUc8cKeIZKHiWgEHmKO1s8QAZ48gjkkbDaNgpCxHt2glMeoFnkm0/psabOynfMV6TcJGpVsx5dVteuEUraHrjJPSf//BtRV49idL5h3dtWjJMg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OjBIg7XzZ2YIUEJ/NT/J6rKc21Lfg06xyBcnMMpGqe36Ir/aePLT3uj8l0R5nSbPddCif2LJ5Vm4sC7f1Iz21PMbiP8+M15OHtUZBtsaEUiUpyZkEjbdDKglPyXgTfosFHL/oZPr6xKh8zgHGMK8LlWm08PtLTsg/CsYV+kJw+p8xT6qokZVQqxyMN0QwaANFMr6hIIvXf5KQNA09ELYDdljYeGTNpGVujJJ+soF20D+7PyEtMOghKmkcGmzUCGr6UNygZWj3IRCAesnjMuHAPWvaRZSTKETL1hJ6SAY4r0Enquc3atAYFQM+SEkAaEFmpYUnTyZKoObcSWUsr4IfQ==
  • Cc: <andrea.bastoni@xxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marco Solieri <marco.solieri@xxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 05 Feb 2024 10:08:28 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>


On 05/02/2024 10:39, Jan Beulich wrote:
> 
> 
> On 03.02.2024 12:43, Carlo Nonato wrote:
>> On Thu, Feb 1, 2024 at 3:19 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>>> On 29.01.2024 18:18, Carlo Nonato wrote:
>>>> @@ -950,6 +951,11 @@ void __init create_domUs(void)
>>>>  #endif
>>>>          }
>>>>
>>>> +        dt_property_read_string(node, "llc-colors", &llc_colors_str);
>>>> +        if ( !llc_coloring_enabled && llc_colors_str)
>>>> +            printk(XENLOG_WARNING
>>>> +                   "'llc-colors' found, but LLC coloring is disabled\n");
>>>
>>> Why's this just a warning, when ...
>>
>> This informs the user that this configuration will be ignored, but the DomU 
>> can
>> be constructed anyway...
> 
> Yet that's a violation of the principle that Julien had outlined when
> discussing whether to panic() in such cases. The property indicates to
> me that the domain ought to be run with coloring enabled, i.e. not much
> different from ...
> 
>>>> @@ -960,6 +966,11 @@ void __init create_domUs(void)
>>>>              panic("Error creating domain %s (rc = %ld)\n",
>>>>                    dt_node_name(node), PTR_ERR(d));
>>>>
>>>> +        if ( llc_coloring_enabled &&
>>>> +             (rc = domain_set_llc_colors_from_str(d, llc_colors_str)) )
>>>> +            panic("Error initializing LLC coloring for domain %s (rc = 
>>>> %d)\n",
>>>> +                  dt_node_name(node), rc);
>>>
>>> ... this results in panic()?
>>
>> ... while here we can't continue because there's some error in the
>> configuration and the DomU can't be constructed. Domains must have a valid
>> coloring configuration.
> 
> ... the request not being possible to fulfill here.
+1
If the user requests a certain functionality which cannot be fulfilled, we 
shall panic.
Take a look at e.g. sve, static-shmem, vpl011.

~Michal



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.