[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v2 2/2] xenpm: Print message for disabled commands
On Thu, Jan 25, 2024 at 9:31 AM Jan Beulich <jbeulich@xxxxxxxx> wrote: > > On 24.01.2024 21:59, Jason Andryuk wrote: > > xenpm get-cpufreq-states currently just prints no output when cpufreq is > > disabled or HWP is running. Have it print an appropriate message. The > > cpufreq disabled one mirros the cpuidle disabled one. > > > > cpufreq disabled: > > $ xenpm get-cpufreq-states > > Either Xen cpufreq is disabled or no valid information is registered! > > > > Under HWP: > > $ xenpm get-cpufreq-states > > P-State information not supported. Try get-cpufreq-average or start. > > > > Also allow xenpm to handle EOPNOTSUPP from the pmstat hypercalls. > > EOPNOTSUPP is returned when HWP is active in some cases and allows the > > differentiation from cpufreq being disabled. > > > > Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx> > > Largely okay, but a number of cosmetic remarks / nits: Thanks for taking a look. Sorry about the cosmetic issues. All your suggestions are good with me. Thanks, Jason
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |