[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] x86/xen: Add some null pointer checking to smp.c
- To: Markus Elfring <Markus.Elfring@xxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Jürgen Groß <jgross@xxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, x86@xxxxxxxxxx
- From: Kunwu Chan <chentao@xxxxxxxxxx>
- Date: Mon, 22 Jan 2024 15:47:01 +0800
- Cc: kernel test robot <lkp@xxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>
- Delivery-date: Mon, 22 Jan 2024 07:47:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 2024/1/19 18:40, Markus Elfring wrote:
kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful
by checking the pointer validity.
…
---
Changes in v3:
- Remove rc initialization
- Simply error paths by adding a new label 'fail_mem'
…
I became curious if you would like to simplify further source code places.
This function hasn't changed in years, so it's OK for now.
+++ b/arch/x86/xen/smp.c
@@ -65,6 +65,8 @@ int xen_smp_intr_init(unsigned int cpu)
char *resched_name, *callfunc_name, *debug_name;
resched_name = kasprintf(GFP_KERNEL, "resched%d", cpu);
+ if (!resched_name)
+ goto fail_mem;
Would you like to add a blank line after such a statement?
Sure, I could do it in next patch.
per_cpu(xen_resched_irq, cpu).name = resched_name;
…
Please compare with your subsequent suggestion.
I’ve seend a reply.
…
@@ -101,6 +108,9 @@ int xen_smp_intr_init(unsigned int cpu)
}
callfunc_name = kasprintf(GFP_KERNEL, "callfuncsingle%d", cpu);
+ if (!callfunc_name)
+ goto fail_mem;
+
per_cpu(xen_callfuncsingle_irq, cpu).name = callfunc_name;
…
Regards,
Markus
--
Thanks,
Kunwu
|
