[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH v5 1/5] x86/HVM: split restore state checking from state loading
On Wed, Jan 10, 2024 at 03:57:06PM +0100, Jan Beulich wrote: > ..., at least as reasonably feasible without making a check hook > mandatory (in particular strict vs relaxed/zero-extend length checking > can't be done early this way). > > Note that only one of the two uses of "real" hvm_load() is accompanied > with a "checking" one. The other directly consumes hvm_save() output, > which ought to be well-formed. This means that while input data related > checks don't need repeating in the "load" function when already done by > the "check" one (albeit assertions to this effect may be desirable), > domain state related checks (e.g. has_xyz(d)) will be required in both > places. > > With the split arch_hvm_{check,load}(), also invoke the latter only > after downing all the vCPU-s. > > Suggested-by: Roger Pau Monné <roger.pau@xxxxxxxxxx> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx> Thanks, Roger.
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |