[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 7/7] xen/arm: smmu-v3: address violations of MISRA C:2012 Rule 16.3
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 5 Jan 2024 15:14:54 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+XT5fN8X8PNaqRLJd1A23nK8nI39vK+Zl192zIDlJdI=; b=OUJiUUWZrySBkZP5TWy5nEk89Fl48eQKuDyGkO35gdYAaJnOy1HuHiZOVePxYmz7aD5wmVxI7eoH7Bksmh6YVf1Pn8a39q5a/zuIZtuoGT2eqq0h6k45mqJm3VcXSS/9xEHas1LNO3AdX1DXjlO5SjuAA/2ERbnm6n//XFyBHrd43Dhv6mHxqy1d7ElCEtYFAb5PrQfpVHM8/zfD17aa3xeAd0WYhXhwGN9IHbYWCJtKcrkRLh89gxjIZYY1jCS0eXI849kOxak3n0PvjIChsRUlmm0vyjedIrUN3ZMQXrRYL+PfNwgsKLaHBdXshV5MtXrz22pMeqzutuaiTBNZ5g==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+XT5fN8X8PNaqRLJd1A23nK8nI39vK+Zl192zIDlJdI=; b=bVJpYJB7U81RZ1ONiW9dJyQYsJpNy5n3c3Iqjo+XEqE3r1pc0vIknYuOnBfVdBBFXNXLkL5RZLQ9snsvr6k8/9uEXUBEu4eqSrt/ckD1IagVDXBmLD5RZYj9PQ7uoY/nDwBEWyANcJ7eC6MFPMH8CnAmY8LNBkEPOFuEH7cJxC6FFxc84s3rJxdOz872IV6uiwq8tYEtlopDnLwYV2C9iYP8IjBEhgqd0Pk8JbGbGFJmyoWCAk8YdWh0U52PjhQLitjGQIYCwIaPohi/QRKqq6lVFFWQ2kbhRl4hsVIDZz4qi4LANpKOOulyBot3+KB0NRkEznQ5YC2ciQPtNZ0scg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=KxwojB/YABp/DLbiQTZmsJh/PS0xdQZuKOEWfLksb72RtYFc7h+HsIU6hrJMrsfcV+COHlok1jIyNf3c/QJaABjswWlkOy1I06epB+PXpedovqaUMhoJXr0f6OibmDQeJwE+/9ok8CjHEbLmV13ny2ZdgGLqNA769FGtegkMlosMQHzExHcy4Fj0QLq72ql2riXoWQ+hsXUUgdXTFUgp+BzDbYiRywuEsCFJiNjLr0ni5VhCZmHZd4LPazVaIeM6Ud4qmGYA+e5/mPhcLdQeJ2djqgGr5KdvKUJ5l+2AYFOL+MpMuuFINy1XfLlaAs4C4vxdqVYtFL+l8p9dr6pG8A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N8CuwJpdM86dJxrGGOR0C3pvB32M7owT0dR0NTS0nEdJZYmpZSbYAmuEEelXL5W8oDKHJq2lvS3VB4YJfJaLDvnsqEUkB9woakpgfs9OunVmAo6GY88nIPS6C87cc6tI9/Zq6l8BNhYXXGue7sra07vw4hgX3Di/NPwHXz+lwP+aalmRFvHqw/S1Bd0HMxjBBK3P7AkjbkkMkaXR0wT4MWKOd127xRtY4z+8hfG+RvbRHio+YW10vLT27XrvV7UhCRyzlfz1IWV1nqcUAhO7BUtaqXMt+UmNRfyrYzP5HY5h4zH/6ETUDEM2W2Mgl6G1MK9Ua2gUQ2wosLaZrlf9Tg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "consulting@xxxxxxxxxxx" <consulting@xxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Fri, 05 Jan 2024 15:15:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHaMzQuu+t0ikhiokmCnvr+/E49RLDLbWoA
- Thread-topic: [XEN PATCH 7/7] xen/arm: smmu-v3: address violations of MISRA C:2012 Rule 16.3
Hi Frederico,
Sorry to have missed that one.
> On 20 Dec 2023, at 12:03, Federico Serafini <federico.serafini@xxxxxxxxxxx>
> wrote:
>
> Add a break statement at the end of the switch-clauses to address
> violations of MISRA C:2012 Rule 16.3 ("An unconditional `break'
> statement shall terminate every switch-clause").
> No funtional change.
>
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx
Cheers
Bertrand
> ---
> xen/drivers/passthrough/arm/smmu-v3.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/xen/drivers/passthrough/arm/smmu-v3.c
> b/xen/drivers/passthrough/arm/smmu-v3.c
> index cdbb505134..bca5866b35 100644
> --- a/xen/drivers/passthrough/arm/smmu-v3.c
> +++ b/xen/drivers/passthrough/arm/smmu-v3.c
> @@ -2200,6 +2200,7 @@ static int arm_smmu_device_hw_probe(struct
> arm_smmu_device *smmu)
> fallthrough;
> case IDR0_STALL_MODEL_STALL:
> smmu->features |= ARM_SMMU_FEAT_STALLS;
> + break;
> }
>
> if (reg & IDR0_S2P)
> @@ -2301,6 +2302,7 @@ static int arm_smmu_device_hw_probe(struct
> arm_smmu_device *smmu)
> fallthrough;
> case IDR5_OAS_48_BIT:
> smmu->oas = 48;
> + break;
> }
>
> smmu->oas = min_t(unsigned long, PADDR_BITS, smmu->oas);
> --
> 2.34.1
>
|
