Re: Ping: [PATCH] Argo: drop meaningless mfn_valid() check

[Christopher Clark <christopher.w.clark@xxxxxxxxx>]

On Sat, Dec 23, 2023 at 12:47 PM Christopher Clark
<christopher.w.clark@xxxxxxxxx> wrote:
>
> On Sun, Dec 17, 2023 at 11:55 PM Jan Beulich <jbeulich@xxxxxxxx> wrote:
> >
> > Christopher,
> >
> > On 27.11.2023 14:55, Jan Beulich wrote:
> > > Holding a valid struct page_info * in hands already means the referenced
> > > MFN is valid; there's no need to check that again. Convert the checking
> > > logic to a switch(), to help keeping the extra (and questionable) x86-
> > > only check in somewhat tidy shape.
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Christopher Clark <christopher.w.clark@xxxxxxxxx>

I'd like to hold off on this just yet, sorry -- the change does look
ok as far as a transform being applied the prior logic and the
necessity of the check, but with it applied, it's not obvious that it
handles all the page types as best that it could there, so I'd like to
look at this (and the previously submitted patch again) please.

Christopher