Re: [PATCH v6 5/9] xen/asm-generic: introduce stub header numa.h

[Oleksii <oleksii.kurochko@xxxxxxxxx>]

On Fri, 2023-12-22 at 09:22 +0100, Jan Beulich wrote:
> On 21.12.2023 20:09, Julien Grall wrote:
> > On 20/12/2023 14:08, Oleksii Kurochko wrote:
> > > <asm/numa.h> is common through some archs so it is moved
> > > to asm-generic.
> > > 
> > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> > > Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
> > > Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> > > Acked-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
> > 
> > I think this patch will need to be rebased on top of the lastest
> > staging 
> > as this should clash with 51ffb3311895.
> 
> No, and I'd like to withdraw my ack here. In this case a stub header
> isn't
> the right choice imo - the !NUMA case should be handled in common
> code. I
> would have submitted the patch I have, if only the first_valid_mfn
> patch
> hadn't been committed already (which I now need to re-base over).
I haven't seen your patch yet (waiting for it), but I assume that
<asm/numa.h> will still be necessary and remain the same across Arm,
PPC, and RISC-V.

What am I missing?

~ Oleksii