Re: [PATCH v2 5/7] xen/ppc: Enable bootfdt and boot allocator

[Julien Grall <julien@xxxxxxx>]

Hi,

On 15/12/2023 02:44, Shawn Anastasio wrote:
> Move PPC off the asm-generic setup.h and enable usage of bootfdt for
> populating the boot info struct from the firmware-provided device tree.
> Also enable the Xen boot page allocator.
>
> Includes minor changes to bootfdt.c's boot_fdt_info() to tolerate the
> scenario in which the FDT overlaps a reserved memory region, as is the
> case on PPC when booted directly from skiboot. Also includes a minor
> change to record Xen's correct position on PPC where Xen relocates
> itself to at the entrypoint.
>
> Signed-off-by: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
> ---
>   xen/arch/ppc/include/asm/Makefile |   1 -
>   xen/arch/ppc/include/asm/setup.h  | 123 +++++++++++++
>   xen/arch/ppc/setup.c              | 289 +++++++++++++++++++++++++++++-
I might be missing something. But isn't most of the code you add is the 
same as Arm? And if so, shouldn't this be consolidated?
I would also expect RISC-V to need the same.

Cheers,

--
Julien Grall