[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen/arm: ffa: return FFA_RET_NOT_SUPPORTED on unhandled calls
- To: Jens Wiklander <jens.wiklander@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 13 Dec 2023 14:06:10 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=linaro.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZJ8xRrHr9x3n9TjjgIiNwbuD/ioa+Thq+NJC8Urfb0c=; b=EYTVc1NmceQNXhs7iQ2Zx8umBV3Ze9I/F4tZ2PutU75QBufqvNy/uHD4P2YIdPfSzP9IOgOwUeHVqKVN5Y415JPDs1ZTc7wKPdxKQOiY6OmPhCXhCgC30cJgFR1ao1d6GkDHI6KpqX7nyP2BEbQ0DTFrOUC63Be8ph6iUEkuFdZROn4KqDbXiIenEKl5NwhxiDtLkAiYtuQTRTIw0Z6xg9Hqiysk226xD4mvKf8UsvEco4J4o8KgPRR7g/AevjpxzS3c9MKLJhJESgvCXSPIOgJeB+xkJZ3Y1KK9CZyKOASos/2NvTJNpS7vUXHWizz75Ho7tF2PMeeRNI8bimoKcQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mk0JkhQEeLSO2IAADrw98R0MSkJxuhOBXpB65Ey1sdNNo0ztKCeZKHSG+iVVvc4GEyqlLoprOrRom1n+DGgjmbhuQtd6ybs3UroVLcvlgEwV6DEP39xcpsBZzPmRgUAYAxjZGO3zBcmsseWeif+zwGPw8uGdFMaiBWCVl+v89qdEVBME67XsxDdz1xejoCU20sXOCAFwwvbQsz4oca3CFmLNzr/XRfqD9luIindbsBE8T9PxWPyA3AZo6fz4bgaYmrv2nrPeOsvgLpX2GzOOh5FjORjne3TnJmbVmU+fpiGU2XWbgLe2difwAnaiqoBNbUcsKHzAZYjm8pBx6ULEWQ==
- Cc: <patches@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Wed, 13 Dec 2023 13:06:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi,
On 13/12/2023 11:32, Jens Wiklander wrote:
>
>
> Until now has an unsupported FF-A request been reported back with
NIT: I think 'has' is in the wrong place
> ARM_SMCCC_ERR_UNKNOWN_FUNCTION in register x0. A FF-A caller would
> rather expect FFA_ERROR in x0 and FFA_RET_NOT_SUPPORTED in x2 so update
> ffa_handle_call() to return true and with the cpu_user_regs updated.
>
> Fixes: 38846de2176b ("xen/arm: tee: add a primitive FF-A mediator")
> Signed-off-by: Jens Wiklander <jens.wiklander@xxxxxxxxxx>
Looking at Linux and TFA, this is indeed expected behavior, so:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
