On Tue, Dec 12, 2023 at 09:48:46AM +0100, Juergen Gross wrote:
On 12.12.23 09:38, Roger Pau Monné wrote:
On Fri, Dec 08, 2023 at 04:02:25PM +0000, Anthony PERARD wrote:
This is following a failure to build "arch/x86/xen/enlighten.c" in
build-i386-pvops jobs with linux 968f35f4ab1c ("Merge tag
'v6.7-rc3-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6")
in linux-linus branch.
Could we expand a bit on why CONFIG_X86_GENERIC is required? It would
seem to me that option should have been selected by default already?
No, the kernel's default for 32-bit x86 builds is still using the M686.
I guess this is for historical reasons.
If I add the following to the patch description, taken from Juergen
patch, would that be ok?
Today the cpu type for a 32-bit x86 kernel is not specified in the
used kernel config, resulting in the M686 to be used.
Instead of using the M686 which isn't even a 64-bit cpu (thus not
capable to run a Xen guest), use the X86_GENERIC variant which is
more appropriate.
ref: https://lore.kernel.org/all/20231207080953.27976-1-jgross@xxxxxxxx/
I'm not sure what you mean Juergen with "not 64bit cpu -> can't run xen
guest", maybe it's because we can only run Xen on 64-bit cpus nowadays,
so if we can't run Xen, there's no Xen guest?
