Re: [PATCH] tools/xenstored: potentially split trace_io() out message

[Julien Grall <julien@xxxxxxx>]

Hi,

On 12/12/2023 06:26, Juergen Gross wrote:
> On 11.12.23 20:11, Julien Grall wrote:
> > Hi Juergen,
> >
> > On 23/11/2023 16:08, Juergen Gross wrote:
> > > Today write_messages() will call trace_io() after having written the
> > > complete message to the ring buffer or socket.
> > >
> > > In case the message can't be written in one go, split it by writing
> > > one trace entry when starting the write and one when finishing it.
> > >
> > > Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> > With one remark below:
> >
> > Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > > ---
> > > This patch is meant to go on top of the patch "tools/xenstored: remove
> > > \"-V\" command line option" in order to not lose any possible debug
> > > information.
> > > ---
> > >   tools/xenstored/core.c | 30 ++++++++++++++++++++----------
> > >   1 file changed, 20 insertions(+), 10 deletions(-)
> > >
> > > diff --git a/tools/xenstored/core.c b/tools/xenstored/core.c
> > > index 9046b200bc..a14b240ed9 100644
> > > --- a/tools/xenstored/core.c
> > > +++ b/tools/xenstored/core.c
> > > @@ -121,7 +121,7 @@ void trace(const char *fmt, ...)
> > >   static void trace_io(const struct connection *conn,
> > >                const struct buffered_data *data,
> > > -             int out)
> > > +             const char *type)
> > This change seems somewhat unrelated. It would be worth mentioning it 
> > in the commit message.
> > If you propose a new wording, I can update it while committing.
> What about:
>
> In order to distinguish a complete OUT message from a split one, let the
> caller of trace_io specify the prefix string ("IN", "OUT", "OUT(START)",
> "OUT(END)") directly instead via an int.
Ah... I spotted the "OUT(END)" but somehow I didn't make the connection 
with the update of trace_io() prototype.
It is now committed.

Cheers,

--
Julien Grall