[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [PATCH] tools/pygrub: Drop compatibility symlink
On Thu, Nov 23, 2023 at 04:30:23PM +0000, Andrew Cooper wrote: > This was declared deprecated in commit 10c88f1c18b7 ("tools: Install pv > bootloaders in libexec rather than /usr/bin") in 2012 This commit only speak about wanting to deprecate the full path to `pygrub`, and calling something deprecated in a commit message alone isn't very friendly. But there's a better commit calling for the deprecation: c31d6a7ee2ea ("libxl: Warn that /usr/bin/pygrub is deprecated") even if it's only in a libxl log message at run time. I hope we have a better schema to deprecate things. > Take it out fully now, 11 years later. > > Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Beside the commit message that could call for a better commit, patch looks good: Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx> Thanks, -- Anthony PERARD
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |