[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed

To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
From: Julien Grall <julien@xxxxxxx>
Date: Mon, 11 Dec 2023 12:32:16 +0000
Cc: consulting@xxxxxxxxxxx, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
Delivery-date: Mon, 11 Dec 2023 12:32:30 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi,

On 11/12/2023 10:30, Nicola Vetrini wrote:

The branches of the switch after a call to 'do_unexpected_trap'
cannot return, but there is one path that may return, hence
only some clauses are marked with ASSERT_UNREACHABLE().

I don't understand why this is necessary. The code should never bereachable because do_unexpected_trap() is a noreturn().


Cheers,

--
Julien Grall

Follow-Ups:
- Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed
  - From: Julien Grall
- Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed
  - From: Nicola Vetrini

References:
- [XEN PATCH 0/7] address violations of MISRA C:2012 Rule 2.1
  - From: Nicola Vetrini
- [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed
  - From: Nicola Vetrini

Prev by Date: Re: [XEN PATCH 3/7] xen/arm: address MISRA C:2012 Rule 2.1
Next by Date: Re: [XEN PATCH] automation/eclair: add deviations for MISRA C:2012 Rule 16.3
Previous by thread: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed
Next by thread: Re: [XEN PATCH 5/7] xen/arm: traps: add ASSERT_UNREACHABLE() where needed
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.