[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 3/5] automation: Add the expect script with test case for FVP


  • To: Henry Wang <Henry.Wang@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Michal Orzel <michal.orzel@xxxxxxx>
  • Date: Fri, 8 Dec 2023 09:57:27 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=arm.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0)
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XN12JkQGBwSaOfSvP9mZi0zL+J7NZwkhkTthFK1VfDw=; b=CWoJcjBWuVMFH8UW50O73dGVqMZXFGzTdQKR7JA3B57RR+Wh0C5uEyQ4EuHpgU/mP4hhv19NQq0Y4CwITzfPcZY72368mv+73MWzTlHpv0q9kSjJdcgRC6OriWnsNetekWGjQRv64vvQrAIkqWJKhMS/HB6u7gg5xiFV0RxQ8TFI/2U5A4ftPVWyslYHGiIWXMZOGHxbNVpYcZt1tx5TMxvOYfvL1fTQSFsGPm+H6syFdjSJ/6m7c5h2ufMZSqXXKFtieLBx91xfzCCng/Rv2Zh5o0gRO9KXgPgE+ic/vYsm8emKTEC7eZb9SzO8xOT4pE/6uuSRswKwttlXap37bg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NcrhrAY7FtHbANvi7c1WdRJuqgvPmLai31B9abFDSECwMiBlKHZHaiKPW9U9XQyCBiqoQjjJEB0NU0pv9eL7USExWMvz2IJAXXyFTKYg9Y6gd8RjSM+dPHpcp2iDnxCy2qrzmLilYYsfW+AhTSWRK+Wo6K1fxovq9jKVzKSQTBSqh9AQ9IZnOdHOiQULgSGy8WbWilLVd4Seh1yzuGwc8xLRzDcaWNVm2h7/1YVVcRBxCBcZeuMUFHxdL9hjaLSwQqmT4r5D21ysHct02vBHu1r3ViH5nIFVsfIWPPnPVqSfCyO2kdJsP1tAuojNNw+CtFsdXGO77oCjOxpBdqsWyg==
  • Cc: Doug Goldstein <cardoe@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Wei Chen <wei.chen@xxxxxxx>
  • Delivery-date: Fri, 08 Dec 2023 08:57:43 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Henry,

On 08/12/2023 06:46, Henry Wang wrote:
> 
> 
> To interact with the FVP (for example entering the U-Boot shell
> and transferring the files by TFTP), we need to connect the
> corresponding port by the telnet first. Use an expect script to
> simplify the automation of the whole "interacting with FVP" stuff.
> 
> The expect script will firstly detect the IP of the host, then
> connect to the telnet port of the FVP, set the `serverip` and `ipaddr`
> for the TFTP service in the U-Boot shell, and finally boot Xen from
> U-Boot and wait for the expected results by Xen, Dom0 and DomU.
> 
> Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>

with 1 question...

> ---
> v2:
> - No change.
> ---
>  .../expect/fvp-base-smoke-dom0-arm64.exp      | 73 +++++++++++++++++++
>  1 file changed, 73 insertions(+)
>  create mode 100755 automation/scripts/expect/fvp-base-smoke-dom0-arm64.exp
> 
> diff --git a/automation/scripts/expect/fvp-base-smoke-dom0-arm64.exp 
> b/automation/scripts/expect/fvp-base-smoke-dom0-arm64.exp
> new file mode 100755
> index 0000000000..25d9a5f81c
> --- /dev/null
> +++ b/automation/scripts/expect/fvp-base-smoke-dom0-arm64.exp
> @@ -0,0 +1,73 @@
> +#!/usr/bin/expect
> +
> +set timeout 2000
Do we really need such a big timeout (~30 min)?
Looking at your test job, it took 16 mins (quite a lot but I know FVP is slow
+ send_slow slows things down)

~Michal




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.