Re: [XEN PATCH v2 1/5] x86/acpi: remove acpi_pic_sci_set_trigger()

[Federico Serafini <federico.serafini@xxxxxxxxxxx>]

On 07/12/23 10:19, Jan Beulich wrote:
> On 07.12.2023 09:47, Federico Serafini wrote:
> > Remove apci_pic_set_trigger() declaration: there is no definition and there are
> > no calls to such function in the XEN project.
> >
> > Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> A reference to the offending commit would have been nice, the more that iirc
> I had already gone and fished that out for you.
Is it correct to use Fixes: <id> ("subj") even if there are other
useless entities left?
In particular, this is what I think should be removed:

Functions:
__acpi_acquire_global_lock()
__acpi_release_global_lock()
acpi_save_state{mem,disk}()
acpi_restore_state_mem()
acpi_enter_state()
{save,restore}_rest_processor_state()

Variables:
acpi_wakeup_address

Macros:
ACPI_ACQUIRE_GLOBAL_LOCK()

If you agree with me, I can propose a new patch which includes such 
removals and refers to the offending commit with a Fixes.
--
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)